Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement number protocol forPyBytes#3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
youknowone merged 6 commits intoRustPython:mainfromKaratuss:impl-nb-bytes
Jul 19, 2022

Conversation

Karatuss
Copy link
Contributor

@KaratussKaratuss commentedJul 16, 2022•
edited
Loading

resolved:#3883

@youknowoneyouknowone added the z-ca-2022Tag to track contrubution-academy 2022 labelJul 16, 2022
Co-authored-by: Snowapril <sinjihng@gmail.com>
@fanninpm
Copy link
Contributor

The unexpected success intest_dict is due to something unrelated to your PR. It's fixed inmain, so feel free to rebase.

@youknowone
Copy link
Member

The commit history looking weird.
while upstream is RustPython/RustPython, please trygit rebase -i upstream/main and remove commits you didn't directly authored.

Copy link
Member

@youknowoneyouknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good, thank you!

@youknowoneyouknowone merged commit463b516 intoRustPython:mainJul 19, 2022
@KaratussKaratuss deleted the impl-nb-bytes branchJuly 20, 2022 10:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SnowaprilSnowaprilSnowapril left review comments

@youknowoneyouknowoneyouknowone approved these changes

@qingshi163qingshi163Awaiting requested review from qingshi163

Assignees
No one assigned
Labels
z-ca-2022Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Number Protocol forPyBytes
4 participants
@Karatuss@fanninpm@youknowone@Snowapril
[8]ページ先頭
©2009-2025 Movatter.jp