Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement missing methods toMappingProxy#3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jopemachine
Copy link
Contributor

Fixes#3875.

Snowapril reacted with thumbs up emoji
@jopemachinejopemachineforce-pushed theadd-missing-method-mapping-proxy branch fromd8f7241 toad27a0fCompareJuly 16, 2022 04:14
@youknowoneyouknowone added the z-ca-2022Tag to track contrubution-academy 2022 labelJul 16, 2022
@Snowapril
Copy link
Contributor

As you implement__or__ and__ior__ for mapping proxy, You can also implement number protocol formappingproxy just by connecting the fields. The only fields thatmappingproxy providing for number protocol are__or__ and__ior__. You can do that in this PR or seaprate PR

jopemachine reacted with thumbs up emoji

Copy link
Contributor

@qingshi163qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks Great!

youknowone reacted with thumbs up emoji
@youknowoneyouknowone merged commit715dac9 intoRustPython:mainJul 18, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SnowaprilSnowaprilSnowapril left review comments

@youknowoneyouknowoneyouknowone approved these changes

@qingshi163qingshi163qingshi163 approved these changes

Assignees
No one assigned
Labels
z-ca-2022Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement missing methods toMappingProxy
4 participants
@jopemachine@Snowapril@youknowone@qingshi163
[8]ページ先頭
©2009-2025 Movatter.jp