Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement Number protocol for PyComplex#3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fanninpm merged 3 commits intoRustPython:mainfromfanninpm:complex-pynumber
Jul 10, 2022

Conversation

fanninpm
Copy link
Contributor

Implementation based on#3507.

Snowapril and youknowone reacted with thumbs up emoji
@fanninpmfanninpm marked this pull request as ready for reviewJuly 3, 2022 19:31
Copy link
Contributor

@qingshi163qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great for the implement

youknowone reacted with thumbs up emoji
@youknowoneyouknowone removed their request for reviewJuly 6, 2022 12:38
@Snowapril
Copy link
Contributor

I think Implementing missingPySequenceMethods,PyMappingMethods,PyNumberMethods for some types can be good first issue for first-comer. How do you think?

Copy link
Contributor

@qingshi163qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great!

fanninpm reacted with hooray emoji
@fanninpmfanninpm merged commit11e9d81 intoRustPython:mainJul 10, 2022
@fanninpmfanninpm deleted the complex-pynumber branchJuly 15, 2022 23:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@youknowoneyouknowoneyouknowone approved these changes

@qingshi163qingshi163qingshi163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@fanninpm@Snowapril@youknowone@qingshi163
[8]ページ先頭
©2009-2025 Movatter.jp