Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Impl PySequence Protocol#3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
youknowone merged 46 commits intoRustPython:mainfromqingshi163:sequence-protocol
Mar 12, 2022

Conversation

qingshi163
Copy link
Contributor

@qingshi163qingshi163 commentedOct 15, 2021•
edited by youknowone
Loading

youknowone, Snowapril, zetwhite, and moreal reacted with thumbs up emojiDimitrisJim, Snowapril, and moreal reacted with hooray emoji
@DimitrisJim
Copy link
Member

DimitrisJim commentedOct 16, 2021•
edited
Loading

Mentioning here so it isn't forgotten,ItemProtocol forPyObjectRef should be amended (maybe after#3306?) to also try the sequence protocol after the mapping one (and before trying to grab__getitem__).


// Sequence Protocol
// https://docs.python.org/3/c-api/sequence.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
#[allow(type_complexity)]

Those types are one-time use types.

@youknowone
Copy link
Member

I want to request@Snowapril 's review later. He must have been reviewed those mapping/sequence details when he implementedPyMapping

Snowapril, qingshi163, moreal, and zetwhite reacted with thumbs up emoji

@youknowoneyouknowone marked this pull request as draftOctober 16, 2021 07:24
@youknowone
Copy link
Member

@DimitrisJim I think processing#3306 as it is and work on ItemProtocol after this PR would be simpler.

qingshi163 reacted with thumbs up emoji

@DimitrisJim
Copy link
Member

sounds good to me

@qingshi163qingshi163force-pushed thesequence-protocol branch 2 times, most recently from944eb0d tobaeca0aCompareOctober 17, 2021 09:21
@SnowaprilSnowapril mentioned this pull requestNov 15, 2021
@qingshi163qingshi163 changed the title[WIP] Impl PySequence ProtocolImpl PySequence ProtocolDec 7, 2021
@qingshi163qingshi163 marked this pull request as ready for reviewDecember 7, 2021 17:55
@qingshi163
Copy link
ContributorAuthor

@youknowone will you review this pr?

@Snowapril
Copy link
Contributor

@qingshi163 Hello. Could I ask you is there any progress here?
Does only reviewing required for more progress?

@youknowone
Copy link
Member

I am sorry, I wasn't aware of pending reveiw request

@youknowone
Copy link
Member

@qingshi163 I rebased it to merge, sorry for late review

@youknowoneyouknowone merged commitdef4a2b intoRustPython:mainMar 12, 2022
@qingshi163qingshi163 deleted the sequence-protocol branchMay 11, 2022 17:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DimitrisJimDimitrisJimDimitrisJim left review comments

@youknowoneyouknowoneyouknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@qingshi163@DimitrisJim@youknowone@Snowapril
[8]ページ先頭
©2009-2025 Movatter.jp