- Notifications
You must be signed in to change notification settings - Fork1.4k
Added call_or_unsupported to vm.rs#197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Added call_or_unsupported to vm.rs#197
Uh oh!
There was an error while loading.Please reload this page.
Conversation
BojanKogoj commentedNov 16, 2018
How to write tests to make sure this is working correctly? I would need to catch exception |
windelbouwman commentedNov 17, 2018
You could write rust unit tests, but in this case it might be better to write a python test snippet which catches the exception and tests if the proper exception is raised. You could use try-except-else for this, like is done here:https://github.com/RustPython/RustPython/blob/master/tests/snippets/builtin_hex.py |
cthulahoops commentedNov 17, 2018
Sorry about being slow to respond to this. I'd prefer to see this named something like |
This is to prevent code duplication. Based on#188