Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added call_or_unsupported to vm.rs#197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@BojanKogoj
Copy link
Contributor

This is to prevent code duplication. Based on#188

windelbouwman reacted with thumbs up emoji
@BojanKogoj
Copy link
ContributorAuthor

How to write tests to make sure this is working correctly? I would need to catch exception

@windelbouwman
Copy link
Contributor

You could write rust unit tests, but in this case it might be better to write a python test snippet which catches the exception and tests if the proper exception is raised. You could use try-except-else for this, like is done here:https://github.com/RustPython/RustPython/blob/master/tests/snippets/builtin_hex.py

@windelbouwmanwindelbouwman merged commita17fb3f intoRustPython:masterNov 17, 2018
@BojanKogojBojanKogoj changed the titleWIP: Added call_or_unsupported to vm.rsAdded call_or_unsupported to vm.rsNov 17, 2018
@cthulahoops
Copy link
Collaborator

Sorry about being slow to respond to this.

I'd prefer to see this named something likeapply_operator. I'd probably gived andr names likelhs_method_name andrhs_method_name.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BojanKogoj@windelbouwman@cthulahoops

[8]ページ先頭

©2009-2025 Movatter.jp