- Notifications
You must be signed in to change notification settings - Fork229
Fix validation in list comprehension and pattern comprehension#2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
nafraf wants to merge13 commits intoRedisGraph:masterChoose a base branch fromnafraf:bug#2267
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR is to solve#2267. The proposed changes are:
A new function
AR_EXP_ContainsAgg()
was created to check if AR_ExpNode tree contains an aggregating function.If an aggregating function is found, then the function sets the error message and returns true, otherwise, returns false
The function
FilterTree_Valid()
was modified to receive a second parametercypher_astnode_type_t type
. In case of pattern comprehension or list comprehension type, there is a new validation to check that the predicate is not using aggregation functions.To validate list comprehension, the function ``_AR_ExpNodeFromComprehensionFunction()``` was modified:
CYPHER_AST_LIST_COMPREHENSION
typeTo validate pattern comprehension, the function
buildPatternComprehensionOps()
was modified:CYPHER_AST_PATTERN_COMPREHENSION
type