Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix validation in list comprehension and pattern comprehension#2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nafraf wants to merge13 commits intoRedisGraph:master
base:master
Choose a base branch
Loading
fromnafraf:bug#2267

Conversation

nafraf
Copy link
Contributor

Hi, this PR is to solve#2267. The proposed changes are:

  1. A new functionAR_EXP_ContainsAgg() was created to check if AR_ExpNode tree contains an aggregating function.
    If an aggregating function is found, then the function sets the error message and returns true, otherwise, returns false

  2. The functionFilterTree_Valid() was modified to receive a second parametercypher_astnode_type_t type. In case of pattern comprehension or list comprehension type, there is a new validation to check that the predicate is not using aggregation functions.

  3. To validate list comprehension, the function ``_AR_ExpNodeFromComprehensionFunction()``` was modified:

    1. Validate predicate filters usingCYPHER_AST_LIST_COMPREHENSION type
    2. Validate that aggregation function is not being used in evaluation node
  4. To validate pattern comprehension, the functionbuildPatternComprehensionOps() was modified:

    1. Validate that aggregation function is not being used in evaluation node
    2. Validate filters usingCYPHER_AST_PATTERN_COMPREHENSION type

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@nafraf

[8]ページ先頭

©2009-2025 Movatter.jp