Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement#6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
akarnokd merged 5 commits intoReactiveX:3.xfromsaasquatch:issue-6878
Jan 28, 2020
Merged

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement#6891

akarnokd merged 5 commits intoReactiveX:3.xfromsaasquatch:issue-6878
Jan 28, 2020

Conversation

@slisaasquatch
Copy link
Contributor

@slisaasquatchslisaasquatch commentedJan 28, 2020•
edited by akarnokd
Loading

Resolves#6878

Dropped the oldMaybe.flatMapSingle and replaced it withMaybe.flatMapSingleElement

@akarnokdakarnokd changed the titleIssue 68783.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElementJan 28, 2020
@slisaasquatch
Copy link
ContributorAuthor

Hmm for XFlatMapTest.maybeSingle, if I replaceflatMapSingle().toSingle() withtoSingle().flatMap(), then the test will pass.

@akarnokd
Copy link
Member

The test checks if disposing while in the function, the returnedSingle never gets subscribed to and thus no error is signaled to the downstream or the global error handler. Put an@Ignore on it for now and I'll look into the operator tomorrow.

slisaasquatch reacted with thumbs up emoji

@akarnokdakarnokd added this to the3.0 milestoneJan 28, 2020
@codecov
Copy link

codecovbot commentedJan 28, 2020

Codecov Report

Merging#6891 into3.x willincrease coverage by<.01%.
The diff coverage is100%.

Impacted file tree graph

@@             Coverage Diff              @@##                3.x    #6891      +/-   ##============================================+ Coverage     98.26%   98.26%   +<.01%+ Complexity     6596     6593       -3============================================  Files           741      740       -1       Lines         47334    47293      -41       Branches       6432     6430       -2     ============================================- Hits          46511    46473      -38- Misses          301      302       +1+ Partials        522      518       -4
Impacted FilesCoverage ΔComplexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java100% <100%> (ø)208 <1> (-1)⬇️
...3/internal/operators/maybe/MaybeFlatMapSingle.java100% <100%> (ø)2 <0> (ø)⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java89.9% <0%> (-8.26%)2% <0%> (ø)
...xjava3/internal/observers/FutureMultiObserver.java91.52% <0%> (-3.39%)25% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java92.7% <0%> (-2.61%)2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java94.82% <0%> (-2.59%)6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java95.94% <0%> (-1.36%)2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java98.29% <0%> (-0.86%)2% <0%> (ø)
.../operators/observable/ObservableCombineLatest.java96.17% <0%> (-0.64%)6% <0%> (ø)
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java97.14% <0%> (-0.41%)50% <0%> (ø)
... and12 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb3516b2...ccc3afb. Read thecomment docs.

@akarnokdakarnokd merged commitf1a795d intoReactiveX:3.xJan 28, 2020
@slisaasquatchslisaasquatch deleted the issue-6878 branchJanuary 29, 2020 17:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@akarnokdakarnokdakarnokd approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3.x: Swap Maybe.flatMapSingle and Maybe.flatMapSingleElement ?

2 participants

@slisaasquatch@akarnokd
[8]ページ先頭
©2009-2025 Movatter.jp