NotificationsYou must be signed in to change notification settings
Fork7.6k
Star48.5k

3.x: Add Completable.onErrorResumeWith#6868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

akarnokd merged 1 commit intoReactiveX:3.xfromakarnokd:CompletableOnErrorResumeWith3x

Jan 24, 2020

Merged

3.x: Add Completable.onErrorResumeWith#6868

akarnokd merged 1 commit intoReactiveX:3.xfromakarnokd:CompletableOnErrorResumeWith3x

Jan 24, 2020

Conversation

Copy link

Member

akarnokd commentedJan 24, 2020

This PR adds the missingCompletable.onErrorResumeWith present in the rest of the base classes.

Also marbles forMaybe.onErrorResumeNext andMaybe.onErrorResumeWith have been updated.

Related#6852,#5806

3.x: Add Completable.onErrorResumeWith

0ad2a1e

akarnokd added Enhancement Documentation 3.x labels

Jan 24, 2020

akarnokd added this to the3.0 milestone

Jan 24, 2020

Copy link

codecovbot commentedJan 24, 2020

Codecov Report

Merging#6868 into3.x willincrease coverage by0.02%.
The diff coverage is100%.

@@             Coverage Diff              @@##                3.x    #6868      +/-   ##============================================+ Coverage     98.28%   98.31%   +0.02%- Complexity     6429     6432       +3============================================  Files           719      719                Lines         46744    46746       +2       Branches       6401     6401              ============================================+ Hits          45944    45958      +14+ Misses          283      278       -5+ Partials        517      510       -7

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java	`100% <ø> (ø)`	`185 <0> (ø)`	⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java	`100% <100%> (ø)`	`125 <1> (+1)`	⬆️
...l/operators/observable/ObservableFlatMapMaybe.java	`83.8% <0%> (-11.98%)`	`2% <0%> (ø)`
.../operators/flowable/FlowableBlockingSubscribe.java	`93.02% <0%> (-4.66%)`	`10% <0%> (-1%)`
...tivex/rxjava3/disposables/CompositeDisposable.java	`98.14% <0%> (-1.86%)`	`39% <0%> (-1%)`
...rnal/operators/observable/ObservableSwitchMap.java	`91.57% <0%> (-1.06%)`	`3% <0%> (ø)`
...nternal/operators/observable/ObservableCreate.java	`97.43% <0%> (-0.86%)`	`2% <0%> (ø)`
...perators/single/SingleFlatMapIterableFlowable.java	`95.83% <0%> (-0.84%)`	`2% <0%> (ø)`
...al/operators/observable/ObservableWindowTimed.java	`96.12% <0%> (-0.65%)`	`4% <0%> (ø)`
...3/internal/operators/flowable/FlowableGroupBy.java	`95.59% <0%> (-0.63%)`	`3% <0%> (ø)`
... and18 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatead1840b...0ad2a1e. Read thecomment docs.