- Notifications
You must be signed in to change notification settings - Fork7.6k
3.x: Add onErrorComplete to Flowable, Observable and Single#6867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJan 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## 3.x #6867 +/- ##============================================- Coverage 98.24% 98.21% -0.03%- Complexity 6417 6430 +13============================================ Files 716 719 +3 Lines 46668 46744 +76 Branches 6397 6401 +4 ============================================+ Hits 45847 45911 +64- Misses 295 309 +14+ Partials 526 524 -2
Continue to review full report at Codecov.
|
This was referencedJan 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
onErrorComplete()andonErrorComplete(Predicate)operators to the remaining base classes.Also created the missing marble for
Maybe.onErrorComplete+ 1.Related#6852,#5806