NotificationsYou must be signed in to change notification settings
Fork7.6k
Star48.5k

Rename Single.equals to Single.sequenceEqual#6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

akarnokd merged 3 commits intoReactiveX:3.xfromsaasquatch:issue-6854

Jan 21, 2020

Merged

Rename Single.equals to Single.sequenceEqual#6856

akarnokd merged 3 commits intoReactiveX:3.xfromsaasquatch:issue-6854

Jan 21, 2020

Conversation

Copy link

Contributor

slisaasquatch commentedJan 21, 2020•
edited by akarnokd
Loading

Renamed Single.equals to Single.sequenceEqual and renamed argument names for consistent naming.

Resolves#6854

slisaasquatch added2 commits

January 21, 2020 11:44

Rename Single.equals to Single.sequenceEqual

3c88479

Rename Single.sequenceEqual arguments

73c8de4

akarnokd approved these changes

Jan 21, 2020

View reviewed changes

akarnokd added 3.x Cleanup labels

Jan 21, 2020

akarnokd added this to the3.0 milestone

Jan 21, 2020

vanniktech approved these changes

Jan 21, 2020

View reviewed changes

akarnokd requested changes

Jan 21, 2020

View reviewed changes

src/main/java/io/reactivex/rxjava3/core/Single.java OutdatedShow resolvedHide resolved

Update mentions of renamed parameters

12ce751

Copy link

codecovbot commentedJan 21, 2020

Codecov Report

Merging#6856 into3.x willdecrease coverage by0.07%.
The diff coverage is100%.

@@             Coverage Diff              @@##                3.x    #6856      +/-   ##============================================- Coverage     98.29%   98.22%   -0.08%+ Complexity     6381     6379       -2============================================  Files           715      715                Lines         46524    46524                Branches       6387     6387              ============================================- Hits          45731    45697      -34- Misses          281      297      +16- Partials        512      530      +18

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java	`100% <100%> (ø)`	`151 <1> (ø)`	⬇️
...l/operators/observable/ObservableFlatMapMaybe.java	`83.8% <0%> (-11.27%)`	`2% <0%> (ø)`
.../operators/flowable/FlowableBlockingSubscribe.java	`93.02% <0%> (-4.66%)`	`10% <0%> (-1%)`
.../operators/observable/ObservableFlatMapSingle.java	`91.26% <0%> (-3.97%)`	`2% <0%> (ø)`
...nternal/operators/parallel/ParallelReduceFull.java	`91.08% <0%> (-3.97%)`	`2% <0%> (ø)`
.../internal/disposables/ListCompositeDisposable.java	`98% <0%> (-2%)`	`34% <0%> (-1%)`
...internal/operators/flowable/FlowableSwitchMap.java	`94.39% <0%> (-1.41%)`	`3% <0%> (ø)`
...a3/internal/operators/flowable/FlowableCreate.java	`96.44% <0%> (-1.3%)`	`6% <0%> (ø)`
...eactivex/rxjava3/processors/BehaviorProcessor.java	`98.02% <0%> (-0.99%)`	`49% <0%> (-1%)`
...rxjava3/internal/schedulers/ExecutorScheduler.java	`95.89% <0%> (-0.92%)`	`10% <0%> (ø)`
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update0c84f40...12ce751. Read thecomment docs.