NotificationsYou must be signed in to change notification settings
Fork7.6k
Star48.5k

3.x: Rename combineLatest methods that take an array to combineLatestArray#6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

akarnokd merged 1 commit intoReactiveX:3.xfromvanniktech:combineLatestArray

Aug 28, 2019

Merged

3.x: Rename combineLatest methods that take an array to combineLatestArray#6640

akarnokd merged 1 commit intoReactiveX:3.xfromvanniktech:combineLatestArray

Aug 28, 2019

Conversation

Copy link

Collaborator

vanniktech commentedAug 28, 2019

Renames the methods as suggested

3.x: Rename combineLatest methods that take an array to combineLatest…

92fd7b6

…Array

akarnokd approved these changes

Aug 28, 2019

View reviewed changes

akarnokd added 3.x Cleanup labels

Aug 28, 2019

akarnokd added this to the3.0 milestone

Aug 28, 2019

Copy link

codecovbot commentedAug 28, 2019

Codecov Report

Merging#6640 into3.x willincrease coverage by0.03%.
The diff coverage is100%.

@@             Coverage Diff              @@##                3.x    #6640      +/-   ##============================================+ Coverage     98.12%   98.16%   +0.03%+ Complexity     6192     6189       -3============================================  Files           678      678                Lines         44690    44690                Branches       6165     6165              ============================================+ Hits          43854    43871      +17+ Misses          294      282      -12+ Partials        542      537       -5

Impacted Files	Coverage Δ	Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java	`100% <100%> (ø)`	`561 <1> (ø)`	⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java	`100% <100%> (ø)`	`537 <1> (ø)`	⬇️
...java3/internal/observers/FutureSingleObserver.java	`94.33% <0%> (-3.78%)`	`24% <0%> (-1%)`
...rxjava3/internal/observers/QueueDrainObserver.java	`97.43% <0%> (-2.57%)`	`21% <0%> (-1%)`
...rnal/operators/observable/ObservableSwitchMap.java	`91.57% <0%> (-2.11%)`	`3% <0%> (ø)`
...rxjava3/internal/schedulers/ScheduledRunnable.java	`98.07% <0%> (-1.93%)`	`29% <0%> (-1%)`
...tivex/rxjava3/disposables/CompositeDisposable.java	`98.14% <0%> (-1.86%)`	`39% <0%> (-1%)`
...ternal/operators/observable/ObservablePublish.java	`97.29% <0%> (-1.81%)`	`16% <0%> (-1%)`
.../operators/observable/ObservableFlatMapSingle.java	`89.68% <0%> (-1.59%)`	`2% <0%> (ø)`
...perators/single/SingleFlatMapIterableFlowable.java	`97.5% <0%> (-0.84%)`	`2% <0%> (ø)`
... and17 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea07c45e...92fd7b6. Read thecomment docs.