NotificationsYou must be signed in to change notification settings
Fork7.6k
Star48.5k

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order#6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

akarnokd merged 1 commit intoReactiveX:3.xfromakarnokd:OpNameAndArgCorrections3x

Aug 28, 2019

Merged

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order#6638

akarnokd merged 1 commit intoReactiveX:3.xfromakarnokd:OpNameAndArgCorrections3x

Aug 28, 2019

Conversation

Copy link

Member

akarnokd commentedAug 28, 2019•
edited
Loading

RenamezipIterable tozip
Removezip(ObservableSource<ObservableSource<T>>) andzip(Publisher<Publisher<T>>)
Change the order of thetillTheEnd argument inconcatMapDelayError andconcatMapEagerDelayError to be consistent with other operators taking aboolean parameter beforeprefetch/maxConcurrency.

Related:#6610

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order

d273268

akarnokd added Cleanup 3.x Removal labels

Aug 28, 2019

akarnokd added this to the3.0 milestone

Aug 28, 2019

akarnokd mentioned this pull request

Aug 28, 2019

What's Different in 3.x (tracking issue)#6515

Closed

70 tasks

Copy link

codecovbot commentedAug 28, 2019

Codecov Report

Merging#6638 into3.x willdecrease coverage by0.04%.
The diff coverage is100%.

@@             Coverage Diff              @@##                3.x    #6638      +/-   ##============================================- Coverage     98.16%   98.12%   -0.05%+ Complexity     6180     6174       -6============================================  Files           678      678                Lines         44795    44779      -16       Branches       6177     6177              ============================================- Hits          43975    43940      -35- Misses          279      291      +12- Partials        541      548       +7

Impacted Files	Coverage Δ	Complexity Δ
...operators/observable/ObservableInternalHelper.java	`100% <ø> (ø)`	`13 <0> (-1)`	⬇️
...nal/operators/flowable/FlowableInternalHelper.java	`100% <ø> (ø)`	`13 <0> (-1)`	⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java	`100% <100%> (ø)`	`561 <4> (-1)`	⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java	`100% <100%> (ø)`	`537 <5> (-1)`	⬇️
...l/operators/observable/ObservableFlatMapMaybe.java	`86.8% <0%> (-9.03%)`	`2% <0%> (ø)`
...nternal/operators/observable/ObservableToList.java	`91.42% <0%> (-8.58%)`	`2% <0%> (-1%)`
...tivex/rxjava3/disposables/CompositeDisposable.java	`98.14% <0%> (-1.86%)`	`39% <0%> (-1%)`
...ernal/operators/flowable/FlowableFromIterable.java	`96.25% <0%> (-1.07%)`	`5% <0%> (ø)`
...perators/observable/ObservableMergeWithSingle.java	`99.07% <0%> (-0.93%)`	`2% <0%> (ø)`
...perators/single/SingleFlatMapIterableFlowable.java	`97.5% <0%> (-0.84%)`	`2% <0%> (ø)`
... and13 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefaf6392...d273268. Read thecomment docs.