Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

3.x: Remove methods from test consumers, make internal versions#6526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
akarnokd merged 1 commit intoReactiveX:3.xfromakarnokd:TestConsumerAPIChanges3x
Jun 20, 2019

Conversation

@akarnokd
Copy link
Member

Remove methods from the standard test consumers based on feedback in6153 comment.

Some test support has been moved into theio.reactivex.testsupport package in the form ofTestObserverEx andTestSubscriberEx.

Resolves:#6153

@codecov
Copy link

codecovbot commentedJun 20, 2019

Codecov Report

Merging#6526 into3.x willdecrease coverage by<.01%.
The diff coverage is80%.

Impacted file tree graph

@@             Coverage Diff              @@##                3.x    #6526      +/-   ##============================================- Coverage     98.16%   98.15%   -0.01%+ Complexity     6251     6155      -96============================================  Files           675      675                Lines         45011    44783     -228       Branches       6211     6180      -31     ============================================- Hits          44183    43956     -227  Misses          286      286+ Partials        542      541       -1
Impacted FilesCoverage ΔComplexity Δ
...main/java/io/reactivex/observers/TestObserver.java96.92% <ø> (-3.08%)25 <0> (-25)
...x/internal/operators/flowable/FlowablePublish.java98.52% <ø> (ø)18 <0> (ø)⬇️
.../java/io/reactivex/subscribers/TestSubscriber.java97.61% <ø> (-1.66%)35 <0> (-22)
...ternal/operators/observable/ObservablePublish.java100% <100%> (ø)18 <0> (ø)⬇️
src/main/java/io/reactivex/Completable.java100% <100%> (ø)117 <0> (ø)⬇️
src/main/java/io/reactivex/Single.java100% <100%> (ø)147 <0> (ø)⬇️
...ors/completable/CompletableAndThenCompletable.java96.66% <100%> (ø)2 <0> (ø)⬇️
src/main/java/io/reactivex/Maybe.java100% <100%> (ø)171 <0> (ø)⬇️
.../java/io/reactivex/observers/BaseTestConsumer.java97.23% <50%> (-2.77%)69 <0> (-47)
...tivex/internal/observers/FutureSingleObserver.java94.33% <0%> (-3.78%)24% <0%> (-1%)
... and28 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatede4ce93...5262542. Read thecomment docs.

@akarnokdakarnokd merged commit05c3429 intoReactiveX:3.xJun 20, 2019
@akarnokdakarnokd deleted the TestConsumerAPIChanges3x branchJune 20, 2019 16:15
dariuszseweryn added a commit to dariuszseweryn/RxAndroidBle that referenced this pull requestJul 31, 2019
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
z3ntu pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestSep 15, 2020
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
z3ntu pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestFeb 15, 2021
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
z3ntu pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestApr 1, 2021
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
z3ntu pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestMay 6, 2021
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
Drjacky pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestJul 5, 2021
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
Drjacky pushed a commit to z3ntu/RxAndroidBle that referenced this pull requestSep 7, 2021
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
nrbrook pushed a commit to NRB-Tech/RxAndroidBle that referenced this pull requestMar 29, 2022
According to the below link some test assertions are now not available. Made substitute extensions.ReactiveX/RxJava#6526
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@akarnokd

[8]ページ先頭

©2009-2025 Movatter.jp