- Notifications
You must be signed in to change notification settings - Fork55
Improved OpenMP setup and detection (closes #493)#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR simplifies the OpenMP detection and configuration logic by removing compiler-specific version checks and relying more on direct OpenMP compilation tests. The changes streamline the configure script to test OpenMP support directly rather than inferring support from compiler versions.
Key Changes:
- Removed complex compiler version detection logic (g++, clang) and replaced with direct OpenMP compilation test
- Consolidated OpenMP flag and define settings based on compilation test results
- Updated CI workflow to test on both container and macOS environments
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| configure.ac | Removed ~100 lines of compiler-specific version checks; now sets OpenMP variables directly from compilation test |
| configure | Generated configure script reflecting the simplified configure.ac logic |
| src/Makevars.in | Removed blank line |
| src/Makevars.win | Removed blank line |
| inst/NEWS.Rd | Added changelog entry about simplified OpenMP detection |
| ChangeLog | Added dated entry documenting the OpenMP setup changes |
| .github/workflows/ci.yaml | Added container-based testing and macOS testing with configure output |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
447c738 intomasterUh oh!
There was an error while loading.Please reload this page.
No description provided.