Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improved OpenMP setup and detection (closes #493)#495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 4 commits intomasterfromfeature/openmp
Oct 20, 2025

Conversation

@eddelbuettel
Copy link
Member

No description provided.

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR simplifies the OpenMP detection and configuration logic by removing compiler-specific version checks and relying more on direct OpenMP compilation tests. The changes streamline the configure script to test OpenMP support directly rather than inferring support from compiler versions.

Key Changes:

  • Removed complex compiler version detection logic (g++, clang) and replaced with direct OpenMP compilation test
  • Consolidated OpenMP flag and define settings based on compilation test results
  • Updated CI workflow to test on both container and macOS environments

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
configure.acRemoved ~100 lines of compiler-specific version checks; now sets OpenMP variables directly from compilation test
configureGenerated configure script reflecting the simplified configure.ac logic
src/Makevars.inRemoved blank line
src/Makevars.winRemoved blank line
inst/NEWS.RdAdded changelog entry about simplified OpenMP detection
ChangeLogAdded dated entry documenting the OpenMP setup changes
.github/workflows/ci.yamlAdded container-based testing and macOS testing with configure output

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

@eddelbuetteleddelbuettel merged commit447c738 intomasterOct 20, 2025
6 checks passed
@eddelbuetteleddelbuettel deleted the feature/openmp branchNovember 20, 2025 14:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddelbuettel

[8]ページ先頭

©2009-2025 Movatter.jp