- Notifications
You must be signed in to change notification settings - Fork55
Fixes #229#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixes #229#231
Uh oh!
There was an error while loading.Please reload this page.
Conversation
R/RcppArmadillo.package.skeleton.R Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure we need these but that is minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
:) For sure. I'll delete them and amend.
| call[[1]]<-skelFunUsed | ||
| if ("example_code"%in% names(call)){ | ||
| call[["example_code"]]<-NULL# remove the example_code argument | ||
| } |
eddelbuettelMay 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this the same as removingexample_code from the arguments? Ie we have two cases:
- not set, moves on
- set, removes it
So nowexample_code is effectively remove. I don't have a problem with that (I never used it) but this would need a different deprecation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is removed from the the call object, but the original argument itself is used later on (line 107 of original file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed -- good call!
Enable use of
example_code = FALSEargument inRcppArmadillo.package.skeleton()whenpkgKittenis installed.