- Notifications
You must be signed in to change notification settings - Fork55
conversion of simple_triplet_matrix#192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coatless commentedNov 30, 2017
I'm a bit worried about extending to meet allcustom objects defined. Also, please modify this commit to respect spacing. |
eddelbuettel commentedNov 30, 2017
I think we managed to use |
f88afd8 to41b4ce7Compare41b4ce7 to6de59f2Comparesgsokol commentedDec 1, 2017
|
eddelbuettel commentedDec 1, 2017
Correct. They way you have the test conditioned we should only need a Suggests:. And on the C++ side it just adds another type. I see no harm in that. But as a general rule (to both (!!) of you): I generally still prefer issue ticket discussion so that everybody can pipe inbefore filing PRs. But you two of course have built upsome trust by now, but I remain a very mean maintainer (even if I just merged@coatless 's PR to Rcpp....) |
coatless commentedDec 1, 2017
@eddelbuettel in my defense, I didn't think you would appreciate an issue ticket for a six character change on a single line followed immediately by a PR ticket. |
eddelbuettel commentedDec 1, 2017
To make it plain, we half a dozen communication channels between us. Pick one. Any one. Randomly submitting PRs is always the worse alternative. |
sgsokol commentedDec 4, 2017
I realize that even with this patch we still need to load Matrix package to get it working. This invalidates my comment about time differences in loading Matrix and slam :( |
eddelbuettel commentedDec 4, 2017
Oh well. It'll be in 0.8.300.1.0 which I am currently rev.dep testing. Some fixes by Conrad in 8.300.1. |
A small patch adding conversion of simple_triplet_matrix format from package slam.
Sorry for all these white spaces removing, it's my new editor Atom who's responsible.
If it's too annoying for you, I'll try to disable this feature and submit with only pertinent part of
modifications.