Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

conversion of simple_triplet_matrix#192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sgsokol
Copy link
Contributor

A small patch adding conversion of simple_triplet_matrix format from package slam.
Sorry for all these white spaces removing, it's my new editor Atom who's responsible.
If it's too annoying for you, I'll try to disable this feature and submit with only pertinent part of
modifications.

@coatless
Copy link
Contributor

I'm a bit worried about extending to meet allcustom objects defined.Matrix is one thing as it part of the recommended packages. Not so withslam.

Also, please modify this commit to respect spacing.

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

I think we managed to useslam,SparseM, andSciPy asoptional pieces in the tests. That way they do not bubble up into Depends. I would much prefer to keep it that way if we could.

@sgsokolsgsokolforce-pushed thesimple_triplet_matrix branch 2 times, most recently fromf88afd8 to41b4ce7CompareDecember 1, 2017 11:09
@sgsokol
Copy link
ContributorAuthor

@coatless

  • I don't think that taking into account slam format adds significant charge on the package. The code is small and compared to previous executions only one type check is added;
  • you are right that Matrix is in recommended packages and not slam, but Matrix is much slower to load than slam. So if someone manages to get all he wants from a small package, why to bother him to force to drag a big one?
  • white spaces are respected now.
    @eddelbuettel I didn't find any mention of slam in unit tests (a part in comments) so I've just put the test inif (suppressMessage(require(slam))) {} block.

@eddelbuettel
Copy link
Member

Correct. They way you have the test conditioned we should only need a Suggests:. And on the C++ side it just adds another type. I see no harm in that.

But as a general rule (to both (!!) of you): I generally still prefer issue ticket discussion so that everybody can pipe inbefore filing PRs. But you two of course have built upsome trust by now, but I remain a very mean maintainer (even if I just merged@coatless 's PR to Rcpp....)

sgsokol reacted with thumbs up emoji

@eddelbuetteleddelbuettel merged commit5d01076 intoRcppCore:masterDec 1, 2017
eddelbuettel added a commit that referenced this pull requestDec 1, 2017
@coatless
Copy link
Contributor

@eddelbuettel in my defense, I didn't think you would appreciate an issue ticket for a six character change on a single line followed immediately by a PR ticket.

@eddelbuettel
Copy link
Member

To make it plain, we half a dozen communication channels between us. Pick one. Any one.

Randomly submitting PRs is always the worse alternative.

@sgsokol
Copy link
ContributorAuthor

I realize that even with this patch we still need to load Matrix package to get it working. This invalidates my comment about time differences in loading Matrix and slam :(

@eddelbuettel
Copy link
Member

Oh well. It'll be in 0.8.300.1.0 which I am currently rev.dep testing. Some fixes by Conrad in 8.300.1.

@sgsokolsgsokol mentioned this pull requestDec 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgsokol@coatless@eddelbuettel

[8]ページ先頭

©2009-2025 Movatter.jp