Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Armadillo 8.100, call .sync() before accessing the internal arrays of the SpMat class#171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
binxiangni wants to merge1 commit intoRcppCore:masterfrombinxiangni:master

Conversation

@binxiangni
Copy link
Contributor

@binxiangnibinxiangni commentedAug 31, 2017
edited
Loading

I just call .sync() in as<>() and it works. But it seems a little weird that no error comes out when I don't call .sync() in wrap() before reading those internal arrays of the SpMat class.

@eddelbuettel
Copy link
Member

eddelbuettel commentedAug 31, 2017
edited
Loading

Your tests may be missing the salient fact that we arenot on Armadillo 0.8[01]00.* yet.

But it is good that you are proactive and on top of this.

@binxiangni
Copy link
ContributorAuthor

binxiangni commentedAug 31, 2017
edited
Loading

So in addition to copying armadillo & armadillo_bits to here and modifying as<>(), what else should I do?

@binxiangni
Copy link
ContributorAuthor

I find that I don't need to call .sync() before arma::access::rwp, but I should call that before arma::access::rw, which possibly means no need to call .sync() before directly reading or writing the pointers. I guess that might explain my problem.

@eddelbuettel
Copy link
Member

So in addition to copying armadillo & armadillo_bits to here and modifying as<>(), what else should I do?

I think you can wait for more tests until I had a chance to update Armadillo within RcppArmadillo.

binxiangni reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

eddelbuettel commentedOct 2, 2017
edited
Loading

I am now (at last) at Armadillo 8.100.1. I think I will need the first part of the PR -- as there are some errors -- but there are "issues" with this PR as it covers 80+ files it should not cover (from Armadillo 8.*). Shall we / can we clean that up, or shall I just re-apply the relevant part by hand?

@eddelbuettel
Copy link
Member

(Copying over. Wrote this in#175 by mistake at first.)

This was a very important and timely PR. I had test failures due to SpMat changes, but with your syncing it passes.

Now it so happens that I cannot merge this now, but I will give you full credit in inst/NEWS.Rd. Hope that's ok.

I should have put 8.100.* into a branch earlier. My bad.

eddelbuettel added a commit that referenced this pull requestOct 2, 2017
@eddelbuettel
Copy link
Member

Ok, I folded this into#176 which is now being tested.

@binxiangni
Copy link
ContributorAuthor

Sorry for being late to take action. Being busy with midterms. Kind of difficult to catch you up. So what should I do? As I see, you've removed the redundant files, right?

@eddelbuettel
Copy link
Member

eddelbuettel commentedOct 2, 2017
edited
Loading

No real action item. But if you and@sgsokol can look over the changes I made toRcppArmadilloAs.h in the branch that is behind the#176 PR. It is now running a rev.dep -- we should be good.

@binxiangni
Copy link
ContributorAuthor

I checked it and my part should be fine. Thanks! (btw, the PR number above should be#176 )

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Ooops. Correcting.

@sgsokol
Copy link
Contributor

For me too, it looks OK.

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Again, sorry to both of for sitting on the PRs in a way that then prevented me from merging them.

Lesson learned, I just should not wait for my next RcppArmadillo release cycle.

sgsokol and binxiangni reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

The content of this PR is now in master via#176. Again my apologies for not merging this sooner (maybe into a branch with arma 8.*).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@binxiangni@eddelbuettel@sgsokol

[8]ページ先頭

©2009-2025 Movatter.jp