Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add conversion & unit tests for dgT, dtT & dsTMatrix#136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 11 commits intoRcppCore:masterfrombinxiangni:Tsparse
Jun 18, 2017
Merged

Add conversion & unit tests for dgT, dtT & dsTMatrix#136

eddelbuettel merged 11 commits intoRcppCore:masterfrombinxiangni:Tsparse
Jun 18, 2017

Conversation

@binxiangni
Copy link
Contributor

In order to solve#17 and#114.

@eddelbuettel
Copy link
Member

Wait, there seem to some of the same commits in both pull requests. That's generally not a great idea.

@binxiangni
Copy link
ContributorAuthor

Maybe I should first close this PR.

@eddelbuettel
Copy link
Member

I now merged#135. If we're careful we could probably open this and merge it too.

We can either open, and merge (maybe simplest) or cherry pick the last two commits.

In general, let's try to only work on one open PR at a time. I'm sorry I took four days on the last one but reviewis useful.

@eddelbuettel
Copy link
Member

There is however a conflict now so that would have to be resolved first.

eddelbuettel reacted with thumbs up emoji

@coatless
Copy link
Contributor

Might I suggest for this PR that@eddelbuettel uses a merge squash? In essence, the working history of the branch is condensed into one commit that is added into the master. This keeps all of the changes of the PR together without adding the duplicate history from the previous PR back into the master.

Merge and squash via:

git checkout mastergit merge --squash branch_heregit commit
binxiangni reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Yes. I already used a merge squash on the last one. Trivial from GitHub's GUI.

coatless reacted with thumbs up emoji

@coatless
Copy link
Contributor

Missed that. Awesome!

@eddelbuettel
Copy link
Member

No worries, and thanks for the CLI reminder. Noted, and copied to local README.

@eddelbuettel
Copy link
Member

Tests find on my end in a branch, so in it goes. Hurray :)

@eddelbuetteleddelbuettel merged commitea4875f intoRcppCore:masterJun 18, 2017
@binxiangnibinxiangni deleted the Tsparse branchJune 25, 2017 17:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@binxiangni@eddelbuettel@coatless

[8]ページ先頭

©2009-2025 Movatter.jp