Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bugfixes for Rcpp::exposeClass#886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 5 commits intoRcppCore:masterfrommlysy:rcpp-exposeClass
Jul 25, 2018

Conversation

@mlysy
Copy link
Contributor

Attempts to fix issue#879 and a couple of other minor issues withRcpp::exposeClass, namely:

  • loadRcppClass (called byexposeClass) handles theClass andCppClass arguments correctly now, such that the R and C++ class names for a given module needn't be the same.
  • Therename argument toexposeClass now functions properly.
  • WhenexposeClass is called in the root directory of a package, the generated wrapper code is put insrc andR subdirectories. This behavior is now ignored iffile orRfile contain absolute paths, in which case the files are written there.

A basic unit test for these changes (inst/unitTests/runit.exposeClass.R) is provided.

@eddelbuettel
Copy link
Member

Wow. Thanks! Will study. Could you possibly rebase with master? Your ChangeLog shows you branched after July 12 so you are missing a little bit. It's not critical -- I could always squash-merge as well. (And will hand-adjust ChangeLog.)

@mlysy
Copy link
ContributorAuthor

Sure! (I just distractedly updated only the ChangeLog, here comes the rest...)

@eddelbuettel
Copy link
Member

Interesting changes, eg theClass vsCppClass. Were we operating on the wrong variable? Entirely possible, but also possible this may have side effects :) I trust you tested this?

@mlysy
Copy link
ContributorAuthor

I reran all unitTests and added my own. (There were some errors but not due to my additions; I didn't fix them to focus on the issue the PR is attempting to solve...)

@codecov-io
Copy link

codecov-io commentedJul 24, 2018
edited
Loading

Codecov Report

Merging#886 intomaster willincrease coverage by0.09%.
The diff coverage is50%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #886      +/-   ##==========================================+ Coverage   90.09%   90.18%   +0.09%==========================================  Files          71       71                Lines        3271     3271              ==========================================+ Hits         2947     2950       +3+ Misses        324      321       -3
Impacted FilesCoverage Δ
R/RcppClass.R73.75% <50%> (+3.75%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update12f3c03...586d4db. Read thecomment docs.

@mlysy
Copy link
ContributorAuthor

Hopefully this the correct rebase, moduloChangeLog.

@kevinushey
Copy link
Contributor

Awesome! Thanks for the PR.

While I'm not that familiar with the modules codebase, all of the changes here look sensible and correct, so a thumbs up from me.

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Same here. Will run a rev.dep check just in case.

@eddelbuettel
Copy link
Member

Sorry, got distracted for a bit. Reverse dependency check threw up nothing new, so merging this now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mlysy@eddelbuettel@codecov-io@kevinushey

[8]ページ先頭

©2009-2025 Movatter.jp