Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
bugfixes for Rcpp::exposeClass#886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eddelbuettel commentedJul 24, 2018
Wow. Thanks! Will study. Could you possibly rebase with master? Your ChangeLog shows you branched after July 12 so you are missing a little bit. It's not critical -- I could always squash-merge as well. (And will hand-adjust ChangeLog.) |
mlysy commentedJul 24, 2018
Sure! (I just distractedly updated only the ChangeLog, here comes the rest...) |
eddelbuettel commentedJul 24, 2018
Interesting changes, eg the |
mlysy commentedJul 24, 2018
I reran all unitTests and added my own. (There were some errors but not due to my additions; I didn't fix them to focus on the issue the PR is attempting to solve...) |
codecov-io commentedJul 24, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #886 +/- ##==========================================+ Coverage 90.09% 90.18% +0.09%========================================== Files 71 71 Lines 3271 3271 ==========================================+ Hits 2947 2950 +3+ Misses 324 321 -3
Continue to review full report at Codecov.
|
mlysy commentedJul 24, 2018
Hopefully this the correct rebase, modulo |
kevinushey commentedJul 24, 2018
Awesome! Thanks for the PR. While I'm not that familiar with the modules codebase, all of the changes here look sensible and correct, so a thumbs up from me. |
eddelbuettel commentedJul 24, 2018
Same here. Will run a rev.dep check just in case. |
eddelbuettel commentedJul 25, 2018
Sorry, got distracted for a bit. Reverse dependency check threw up nothing new, so merging this now. |
Attempts to fix issue#879 and a couple of other minor issues with
Rcpp::exposeClass, namely:loadRcppClass(called byexposeClass) handles theClassandCppClassarguments correctly now, such that the R and C++ class names for a given module needn't be the same.renameargument toexposeClassnow functions properly.exposeClassis called in the root directory of a package, the generated wrapper code is put insrcandRsubdirectories. This behavior is now ignored iffileorRfilecontain absolute paths, in which case the files are written there.A basic unit test for these changes (
inst/unitTests/runit.exposeClass.R) is provided.