Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature/complete pr799#800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 3 commits intomasterfromfeature/completePR799
Jan 14, 2018
Merged

Feature/complete pr799#800

eddelbuettel merged 3 commits intomasterfromfeature/completePR799
Jan 14, 2018

Conversation

@eddelbuettel
Copy link
Member

No description provided.

@krlmlr
Copy link
Contributor

I'd preferstd::isnan() because it's faster by another x1.5, but this also comes with a slight risk. What do you think?

@eddelbuetteleddelbuettel mentioned this pull requestJan 14, 2018
@eddelbuettel
Copy link
MemberAuthor

Let's review this in the next cycle. I have much more profound problems with this 0.12.15 candidate now.

@eddelbuettel
Copy link
MemberAuthor

Also, R hasNA andNaN, the standard only has the latter so I prefer R in general for this.

@eddelbuetteleddelbuettel merged commit7d063b4 intomasterJan 14, 2018
@krlmlr
Copy link
Contributor

R'sNA is a specialNaN, always has been, and probably will be forever. But I agree it's safer to useR_cppisnan().

@kevinushey
Copy link
Contributor

R-exts has this to say aboutstd::isnan():

Functions/macros such as isnan, isinf and isfinite are not required by C++98: where compilers support them they may be only in the std namespace or only in the main namespace. There is no way to make use of these functions which works with all C++ compilers currently in use on R platforms: use R’s versions such as ISNAN and R_FINITE instead.

which is a long-winded way of saying, "if you usestd::isnan(), CRAN may yell at you later when it breaks on Solaris". So if we did switch tostd::isnan() we should guard that usage based on whethergcc /clang is being used as the compiler.

@krlmlr
Copy link
Contributor

Thanks. I missed the "C++11" requirement forstd::isnan():http://en.cppreference.com/w/c/numeric/math/isnan. Let's stick with the API.

@eddelbuetteleddelbuettel deleted the feature/completePR799 branchJanuary 14, 2018 22:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eddelbuettel@krlmlr@kevinushey

[8]ページ先頭

©2009-2025 Movatter.jp