Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Generate C++ native routines with underscore prefix#725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Avoid export from package when standard [[ alpha ]] exportPattern is used in NAMESPACE
MemberAuthor
jjallaire commentedJul 2, 2017
Note that if R core decides to stop auto-exporting the registered native symbols then we could revert the use of the underscore prefix. That's something that couldn't happen until the release of R 3.5 though. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Avoid export from package when standard [[ alpha ]] exportPattern is used in NAMESPACE
This addresses#723.
Note that this change does introduce the use of reserved (but not invalid) C/C++ symbols (the underscore prefix). We made some effort last year I recall to remove such symbols from generated attributes code, presumably to get a clean bill of health from linting tools?
I've tried this with Rcpp::interfaces(r, cpp) as well as with the tic.drat package (package with dot in the name). I've also tried it with packages that include their own non-generated native functions. Also of course have run the Rcpp tests. Even still, this will change the code in every existing RcppExports.* file so is worthy of some extra review/caution/testing.