Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Do not use dir.exists to retain backwards-compatibility#698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eddelbuettel left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch.
epipping commentedMay 24, 2017
If compatibility with versions older than 3.2 is important (debian 8.8 still only has 3.1) one might want to turn the |
eddelbuettel commentedMay 24, 2017
Debian 8.8 is irrelevant as its sources for Rcpp match its sources for base R. Plus, we have the actively supported backport for R available via CRAN. We could use thebackports package, or at least Suggests: it if we cared. Team: Anybody see a problem depending on the now-two-year old R 3.2.0 ? |
kevinushey commentedMay 24, 2017
I'm guessing there are a lot of users in enterprise environments who are stuck with R 3.1.x or even R 3.0.x who would appreciate if we could remain compatible with R 3.0.0 and above, so I would be marginally in favor of just using |
eddelbuettel commentedMay 24, 2017
Yes, that is a good policy. I can look into that while traveling the next two days. Of course I would be equally happy to receive a short PR :) |
The function dir.exists was only added in R 3.2
epipping commentedMay 24, 2017
|
jjallaire commentedMay 24, 2017
Yes, we have to remember that we bump our required version we implicitly bump the required version of 92% of CRAN (via recursive dependencies). |
Uh oh!
There was an error while loading.Please reload this page.
The file R/Attributes.R uses the function
dir.exists()whichwas only added in R 3.2.0. The relevant line was added to
R/Attributes.R between 0.12.5 and 0.12.6.