Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do not use dir.exists to retain backwards-compatibility#698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 1 commit intoRcppCore:masterfromepipping:master
May 25, 2017
Merged

Do not use dir.exists to retain backwards-compatibility#698

eddelbuettel merged 1 commit intoRcppCore:masterfromepipping:master
May 25, 2017

Conversation

@epipping
Copy link
Contributor

@epippingepipping commentedMay 24, 2017
edited
Loading

The file R/Attributes.R uses the functiondir.exists() which
was only added in R 3.2.0. The relevant line was added to
R/Attributes.R between 0.12.5 and 0.12.6.

Copy link
Member

@eddelbuetteleddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch.

@epipping
Copy link
ContributorAuthor

If compatibility with versions older than 3.2 is important (debian 8.8 still only has 3.1) one might want to turn thedir.exists back intofile.exists instead.

@eddelbuettel
Copy link
Member

Debian 8.8 is irrelevant as its sources for Rcpp match its sources for base R. Plus, we have the actively supported backport for R available via CRAN.

We could use thebackports package, or at least Suggests: it if we cared.

Team: Anybody see a problem depending on the now-two-year old R 3.2.0 ?

coatless reacted with thumbs down emoji

@kevinushey
Copy link
Contributor

I'm guessing there are a lot of users in enterprise environments who are stuck with R 3.1.x or even R 3.0.x who would appreciate if we could remain compatible with R 3.0.0 and above, so I would be marginally in favor of just usingfile.exists() orutils::file_test("-d", ...) to be backwards compatible -- especially since the change is so small in this case.

coatless reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Yes, that is a good policy. I can look into that while traveling the next two days. Of course I would be equally happy to receive a short PR :)

The function dir.exists was only added in R 3.2
@epippingepipping changed the titleDeclare dependency: R >= 3.2.0Do not use dir.exists to retain backwards-compatibilityMay 24, 2017
@epipping
Copy link
ContributorAuthor

utils::file_test("-d", ...) is the perfect solution for this problem. Since I see no disadvantages in following that route, for simplicity, I've now hijacked my own pull request and turned it into this different solution for the same problem by force-pushing.

coatless reacted with thumbs up emoji

@jjallaire
Copy link
Member

Yes, we have to remember that we bump our required version we implicitly bump the required version of 92% of CRAN (via recursive dependencies).

coatless reacted with thumbs up emoji

@eddelbuetteleddelbuettel merged commitd6ec27f intoRcppCore:masterMay 25, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@eddelbuetteleddelbuetteleddelbuettel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@epipping@eddelbuettel@kevinushey@jjallaire

[8]ページ先頭

©2009-2025 Movatter.jp