Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Explicitly call parent constructor#670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedApr 13, 2017
Codecov Report
@@ Coverage Diff @@## master #670 +/- ##======================================= Coverage 92.91% 92.91% ======================================= Files 65 65 Lines 3303 3303 ======================================= Hits 3069 3069 Misses 234 234 Continue to review full report at Codecov.
|
kevinushey commentedApr 13, 2017
LGTM |
eddelbuettel commentedApr 13, 2017
eddelbuettel commentedApr 13, 2017
And given the very recent change to#671 I just updated to that and restarted. |
eddelbuettel commentedApr 14, 2017
Reverse-depends checkworked just fine, so merging this. |
for copy constructor, to avoid warning in
-Wextra.