Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Use vector for dynamic memory in sample (closes #612)#616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| LaTeX: pdfLaTeX | ||
| AutoAppendNewline: Yes | ||
| StripTrailingWhitespace: Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great!
| @@ -1,8 +1,13 @@ | |||
| 2016-12-13 Nathan Russell <russell.nr2012@gmail.com> | |||
| 2016-12-14 Nathan Russell <russell.nr2012@gmail.com> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup.
| // In order to mirror the behavior of `base::sample` | ||
| // as closely as possible, this file contains adaptations | ||
| #include<vector> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code below looks good. I trust the tests...
codecov-io commentedDec 14, 2016
Current coverage is 62.42% (diff: 100%)@@ master #616 diff @@========================================== Files 69 69 Lines 4798 4798 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 2995 2995 Misses 1803 1803 Partials 0 0
|
This replaces the use of
alloca,Calloc, andFreewithstd::vector.