Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

change hashing function to return unsigned int#561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
eddelbuettel merged 1 commit intoRcppCore:masterfromthirdwing:iss391_patch2
Oct 24, 2016

Conversation

@thirdwing
Copy link
Member

No description provided.

@eddelbuettel
Copy link
Member

Looks good to me!

@eddelbuettel
Copy link
Member

Any other thumbs up besides my overused one?

@coatless
Copy link
Contributor

Change context:

int =>unsigned int since thehashing macro is defined to returnunsigned int

@coatless
Copy link
Contributor

coatless commentedOct 24, 2016•
edited
Loading

Looks likeint addr missed a change over inadd_value_get_index() withinSelfHash.h andadd_value() withinIndexHash.h

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Yes, also see the now closed (because too "jumbo") PR#556

@thirdwing
Copy link
MemberAuthor

I have updated the code.

eddelbuettel and coatless reacted with thumbs up emojicoatless reacted with hooray emoji

@eddelbuettel
Copy link
Member

In it goes!

@eddelbuetteleddelbuettel merged commitadae3fe intoRcppCore:masterOct 24, 2016
@thirdwingthirdwing deleted the iss391_patch2 branchOctober 24, 2016 03:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thirdwing@eddelbuettel@coatless
[8]ページ先頭
©2009-2025 Movatter.jp