Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Sugar cbind with unit tests#447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eddelbuettel commentedMar 13, 2016
Looks pretty good to me. |
| } // cbind_impl | ||
| #define MakeBindable(x) (cbind_impl::detail::MakeBindable(x)(x)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this macro get undefined after we're done using it?
kevinushey commentedMar 14, 2016
Looks great! One minor comment re: potentially cleaning up the |
nathan-russell commentedMar 14, 2016
@kevinushey Thanks for reviewing! I just committed the change. |
eddelbuettel commentedMar 14, 2016
Something went marginally wrong with the commit as GH thinks you changed 830 lines... Not to worry though. |
nathan-russell commentedMar 14, 2016
Oh dear. I made this commit from a Windows machine -- I wonder if that has anything to do with it. |
eddelbuettel commentedMar 14, 2016
That would do it. Hint: I believe even Windoze has some editors that behave like grownups :) Here it doesn't matter. It's a new file anyway. In general, we've been pretty careful about not mass-committing whitespace changes. (With exception:@kevinushey once did a mass commit as I recall; I recently updated a bunch of headers following@ellert's PR, .... -- but in general that is best avoided). We do have a number of skeletons with mixed tab/spaces in the closet though. But no point going crazy about them just for the heck of it... I'll merge this now. Nice work! |
Sugar cbind with unit tests
The latest
cbindimplementation as discussed toward the bottom of#407.