Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Added explicit (const_)string_proxy/SEXP comparisons to resolve ambiguity#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eddelbuettel commentedSep 9, 2015
... and tidyr. Thanks for fixing it and submitting a PR while my rev.dep. check is still running! |
eddelbuettel commentedSep 9, 2015
Ok, I checked and this fixed readr, readxl, rpg and tidyr. We still have package icd9 failing with: |
thirdwing commentedSep 9, 2015
I think add those lines below into |
eddelbuettel commentedSep 9, 2015
Nice work,@thirdwing ! When I looked as @dcdillon Do you want to add this to the PR or shall I just add it after merging? edd@max:/tmp/rcpp-tmp/Rcpp$ diff -u ~/git/rcpp/inst/include/Rcpp/String.h inst/include/Rcpp/String.h --- /home/edd/git/rcpp/inst/include/Rcpp/String.h2015-09-0809:59:23.570918337 -0500+++ inst/include/Rcpp/String.h2015-09-0905:54:04.478869310 -0500@@ -438,6 +438,14 @@return strcmp( get_cstring(), other.get_cstring() ) >0; }+booloperator==( SEXP other )const {+returnget_sexp() == other;+ }++booloperator!=( SEXP other )const {+returnget_sexp() != other;+ }+private:/** the CHARSXP this String encapsulates*/edd@max:/tmp/rcpp-tmp/Rcpp$ Ah shucks, I'll just do it and then start a new test run ... |
Added explicit (const_)string_proxy/SEXP comparisons to resolve ambiguity
This fixes compile failures in readr, readxl, and rpg