Aug 25, 2015 · Aug 17, 2015 · Aug 17, 2015 · Aug 18, 2015 · Aug 19, 2015 · Aug 19, 2015
diff --git a/inst/unitTests/runit.Matrix.R b/inst/unitTests/runit.Matrix.R
        checkEquals(mat_access_with_bounds_checking(m, 3, 2), 12)
        checkException(mat_access_with_bounds_checking(m, 4, 2) , msg = "index out of bounds not detected" )
        checkException(mat_access_with_bounds_checking(m, 3, 3) , msg = "index out of bounds not detected" )
 #checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
 #checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
 #checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
        checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
        checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
        checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
    }

 }
diff --git a/inst/unitTests/runit.Vector.R b/inst/unitTests/runit.Vector.R
        x <- seq(1L, 5L, by=1L)
        checkEquals(vec_access_with_bounds_checking(x, 3), 4)
        checkException(vec_access_with_bounds_checking(x, 5) , msg = "index out of bounds not detected" )
 #checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
        checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
    }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -178,9 +178,9 @@ if (.runThisTest) {
		checkEquals(mat_access_with_bounds_checking(m, 3, 2), 12)
		checkException(mat_access_with_bounds_checking(m, 4, 2) , msg = "index out of bounds not detected" )
Copy link Member eddelbuettelAug 24, 2015 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Am I missing something or should the msg be "index out of bounds" because the fact that we have an exception means your`throw` went into effect? Copy link ContributorAuthor fplazaonateAug 24, 2015 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Actually, the error message is written if there is no error generated (c.f. RUnit documentation) Copy link Member eddelbuettelAug 24, 2015 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I guess you are correct -- if it passes we just get`TRUE`. But if you look at our code the msg field, when we set it all :), mostly just states where this came from. So "matrix bounds check" would be fine, and s/matrix/vector/ for the other one. Not that important. I'll try merge this maybe late this evening if I get to it. It now needs a manual intervention because ChangeLog changed in the meantime ...
		checkException(mat_access_with_bounds_checking(m, 3, 3) , msg = "index out of bounds not detected" )
		#checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
		#checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
		#checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
		checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
		checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
		checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
		}

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -688,7 +688,7 @@ if (.runThisTest) {
		x <- seq(1L, 5L, by=1L)
		checkEquals(vec_access_with_bounds_checking(x, 3), 4)
		checkException(vec_access_with_bounds_checking(x, 5) , msg = "index out of bounds not detected" )
		#checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
		checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
		}
		}