Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

drop support for user-defined databases#1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@kevinushey
Copy link
Contributor

Pull Request Template for Rcpp

Closes#1313.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file inChangeLog

@eddelbuettel
Copy link
Member

Nice catch in#1313. I don't even recall what those user-define dbs were....

@eddelbuettel
Copy link
Member

I am kinda minutes/hours/days from a new release so how would you feel if I delayed this til after the release. Given that@mattfidler saw this I would think we need a full rev.dep check (as we change the API surface) which I would rather avoid now. Thoughts?

@kevinushey
Copy link
ContributorAuthor

For sure, definitely no rush on this (or the other PR I just put up).

eddelbuettel reacted with thumbs up emoji

@mattfidler
Copy link

mattfidler commentedJul 5, 2024
edited
Loading

For me I worked around it, if CRAN does ask for an update I am ready.

I dont mind waiting either.

eddelbuettel reacted with thumbs up emoji

@eddelbuettel
Copy link
Member

Reverse dependency check is now 50% done, no new regressions yet.

@eddelbuettel
Copy link
Member

The reverse depends run had no new issues, so merging this now. Had to do a micro-commit over conflicts in ChangeLog, will do one more clean-up (fixing tabs/spaces etc) once merged and once I increment the micro release.

@eddelbuetteleddelbuettel merged commitd303f9e intomasterJul 22, 2024
@eddelbuetteleddelbuettel deleted the bugfix/user-defined-database-drop-support branchAugust 20, 2024 18:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HASHTAB is no longer allowed

4 participants

@kevinushey@eddelbuettel@mattfidler

[8]ページ先頭

©2009-2025 Movatter.jp