Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
drop support for user-defined databases#1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
eddelbuettel commentedJul 5, 2024
Nice catch in#1313. I don't even recall what those user-define dbs were.... |
eddelbuettel commentedJul 5, 2024
I am kinda minutes/hours/days from a new release so how would you feel if I delayed this til after the release. Given that@mattfidler saw this I would think we need a full rev.dep check (as we change the API surface) which I would rather avoid now. Thoughts? |
kevinushey commentedJul 5, 2024
For sure, definitely no rush on this (or the other PR I just put up). |
mattfidler commentedJul 5, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For me I worked around it, if CRAN does ask for an update I am ready. I dont mind waiting either. |
eddelbuettel commentedJul 21, 2024
Reverse dependency check is now 50% done, no new regressions yet. |
eddelbuettel commentedJul 22, 2024
The reverse depends run had no new issues, so merging this now. Had to do a micro-commit over conflicts in ChangeLog, will do one more clean-up (fixing tabs/spaces etc) once merged and once I increment the micro release. |
Pull Request Template for Rcpp
Closes#1313.
Checklist
R CMD checkstill passes all tests