NotificationsYou must be signed in to change notification settings
Fork219
Star781

Address clang conversion warnings#1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

eddelbuettel merged 2 commits intomasterfromfeature/clang_conversion_warnings

Jan 9, 2023

Merged

Address clang conversion warnings#1240

eddelbuettel merged 2 commits intomasterfromfeature/clang_conversion_warnings

Jan 9, 2023

Conversation

Copy link

Member

eddelbuettel commentedJan 9, 2023

This PR addresses warnings seen when building withclang++-14 -Wall -pedantic -Wconversion -Wno-sign-conversion as done on the CRAN 'M1mac' box. It is a fairly simple set of casts. It seems to make sense to fold this into the pending 1.0.10 even though we otherwise dislike making very last minute changes...

Checklist

Code compiles correctly
R CMD check still passes all tests
Prefereably, new tests were added which fail without the change
Document the changes by file inChangeLog

eddelbuettel added2 commits

January 8, 2023 18:02

Address warnings from clang++-14 under -Wconversion

cb83bdc

Comment coverage out while it seems borked

a15398c

eddelbuettel requested review fromEnchufa2,jjallaire andkevinushey

January 9, 2023 15:06

kevinushey approved these changes

Jan 9, 2023

View reviewed changes

Copy link

Contributor

kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Enchufa2 approved these changes

Jan 9, 2023

View reviewed changes

Copy link

Member

Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Copy link

MemberAuthor

eddelbuettel commentedJan 9, 2023

Thank you both!

eddelbuettel merged commit39669cb intomaster

Jan 9, 2023

eddelbuettel deleted the feature/clang_conversion_warnings branch

January 9, 2023 16:03

Copy link

MemberAuthor

eddelbuettel commentedJan 9, 2023

I will need a one-line follow-up as the change inattributes.cpp now triggers a warning underg++-12. Can't win 😉

ccache g++ -I"/usr/share/R/include" -DNDEBUG -I../inst/include/     -fpic  -g -O2 -Wall -pipe -pedantic  -c attributes.cpp -o attributes.oattributes.cpp: In member function ‘std::stringRcpp::attributes::SourceFileAttributesParser::parseSignature(size_t)’:attributes.cpp:1624:38: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘longunsignedint’}and ‘R_xlen_t’ {aka ‘longint’} [-Wsign-compare]1624 |for (size_t i = lineNumber; i<lines_.size(); i++) {      |                                     ~^~~~~~~~~~~~~~                  ccache g++ -I"/usr/share/R/include" -DNDEBUG -I../inst/include/     -fpic  -g -O2 -Wall -pipe -pedantic  -c barrier.cpp -o barrier.o