Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
Suppress one 'int / unsigned int comparisom' warning#1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Enchufa2 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Due to their similarities, maybe it's a good opportunity to switch touint32_t inSelfHash.h too.
eddelbuettel commentedApr 10, 2021
Agreed. I already did a recursive grep and it is very few files. But not urgent, and I wanted to keep this small. Thanks for the review! |
This addresses the (spurious but tedious) one warning in#1152, and while we are at it, updatesin that file alone the few uses of
unsigned inttouint32_t. The second part is more debatable but should be harmless and does of course test out fine.Checklist
R CMD checkstill passes all tests