NotificationsYou must be signed in to change notification settings
Fork219
Star781

correct package skeleton behavior (closes #1087)#1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

eddelbuettel merged 2 commits intomasterfrombugfix/skeleton

Jun 7, 2020

Merged

correct package skeleton behavior (closes #1087)#1088

eddelbuettel merged 2 commits intomasterfrombugfix/skeleton

Jun 7, 2020

Conversation

Copy link

Member

eddelbuettel commentedJun 6, 2020

This is in relation to#1087 and the fact that the 'package creation helper' (both functions such asRcpp.package.skeleton() andRcppArmadillo.package.skeleton()and the functionality accessible from RStudio via File -> New Project -> Package) suffers from an issue in NAMESPACE.

The fix is simple and gets to it based on my testing today, but someone else should have a look at it.

Checklist

Code compiles correctly
R CMD check still passes all tests
Prefereably, new tests were added which fail without the change
Document the changes by file inChangeLog

Copy link

codecov-commenter commentedJun 6, 2020•
edited
Loading

Codecov Report

Merging#1088 intomaster willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #1088   +/-   ##=======================================  Coverage   95.54%   95.55%           =======================================  Files          64       64             Lines        2784     2789    +5     =======================================+ Hits         2660     2665    +5  Misses        124      124