- Notifications
You must be signed in to change notification settings - Fork0
Update DynamicArrayQueue.java#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
RanchCoder wants to merge1 commit intomasterChoose a base branch fromRanchCoder-patch-1
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
In this DynamicArrayQueue1) When a user is providing capacity for the queue we are not resetting the CAPACITY variable in our constructor function's cap value. we are using our CAPACITY variable further in the code to increment rear and front, so if the actual capacity is not taken into account then we can get a wrong index.The existing code for the expand function is not working for a circular queue scenario.//This loop wont work for circular case when our rear will be pointing to the same location as that of front , i.e // queue[5] = {1,2,3,4,5} , now our rear will be at (rear + 1) % CAPACITY// i.e 0 and loop condition will run only once.// for(int i = front; i <= rear; i ++)// newQueue[i-front] = queueRep[i%CAPACITY];rear = size also has an issueIf we go up till size - 1 then we will be pointing the latest element entered in our queue and not the latest free slot to enter the value rear = size-1. As the size is incremented each time on enqueue and decremented each time at dequeue.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this DynamicArrayQueue
we are using our CAPACITY variable further in the code to increment rear and front, so if the actual capacity is not taken into account then we can get a wrong index.
The existing code for the expand function is not working for a circular queue scenario.
//This loop wont work for circular case when our rear will be pointing to the same location as that of front , i.e
// queue[5] = {1,2,3,4,5} , now our rear will be at (rear + 1) % CAPACITY
// i.e 0 and loop condition will run only once.
// for(int i = front; i <= rear; i ++)
// newQueue[i-front] = queueRep[i%CAPACITY];
rear = size also has an issue
If we go up till size - 1 then we will be pointing the latest element entered in our queue and not the latest free slot to enter the value rear = size-1. As the size is incremented each time on enqueue and decremented each time at dequeue.