Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Draft] Adding support for refining ElementWise, ExpandDims and Broadcast#763

Draft
guacamoleo wants to merge3 commits intorefine-ops-pass
base:refine-ops-pass
Choose a base branch
Loading
fromdtanner/refine_elementwise2

Conversation

guacamoleo
Copy link

This adds the following onto the rebased refine-ops-pass from 3/18:

  • Fixes AMDMfmaEncodingAttr::toLinearLayout to support smaller/refined sizes. Before, too many register bases were being supplied so that ExtractSliceOpToLLVM was calculating the wrong number of elements in packLLElements. Now the right number of register basis vectors are emplated in the newly created linear layout.
  • Add support for refining element-wise ops, including ConvertLayout, also ExpandDims and Broadcast.

The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly,if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

Complete the following tasks before sending your PR, and replace[ ] with
[x] to indicate you have done them.

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have runpre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test forlit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test becauseFILL THIS IN.
  • Select one of the following.

    • I have not added anylit tests.
    • Thelit tests I have added follow thesebest practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@guacamoleoguacamoleoforce-pushed thedtanner/refine_elementwise2 branch from7f5d5f1 to3cec690CompareMarch 19, 2025 15:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@antiagainstantiagainstAwaiting requested review from antiagainstantiagainst will be requested when the pull request is marked ready for reviewantiagainst is a code owner

@zhanglx13zhanglx13Awaiting requested review from zhanglx13zhanglx13 will be requested when the pull request is marked ready for reviewzhanglx13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@guacamoleo

[8]ページ先頭

©2009-2025 Movatter.jp