- Notifications
You must be signed in to change notification settings - Fork158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Loosen check for CLI compiler choices#2116
base:develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, suggestion made
Tensile/Tensile.py Outdated
| default=ToolchainDefaults.CXX_COMPILER, | ||
| type=str, | ||
| help="C++ compiler used when generating binaries." | ||
| " On linux, amdclang++ (default) or hipcc. On Windows clang++ (default) or hipcc.", | ||
| "On Linux, amdclang++ (default) or hipcc. On Windows clang++ (default) or hipcc. " | ||
| "On Windows, file extensions will be searched according to the PATHEXT environment variable. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't it true that you can pass a file extension on windows?
If so maybe "On Windows, include the file extension, or extensions will be searched..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right, this would technically be more correct. Updated.
Resolves#2112
Summary:
Removes overly restrictive choices for
--cxx-compilerwhen invoking Tensile.Outcomes:
The user can pass fully qualified paths to Tensile. There is still a validation check that occurs during program initialization, but this validation is significantly less restrictive compared to setting choices directly in the argument parser.