forked frompythonnet/pythonnet
- Notifications
You must be signed in to change notification settings - Fork29
Do not include timezone if DateTimeKind is Unspecified#15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
DECREF'ing datetime timezone argument when DateTimeKind is Unspecified was causing `Fatal Python error: deallocating None` because the object was set to `Runtime.PyNone`.Fixed the input to datetime constructor as we were passing milliseconds, where it should be microseconds.
ef08a75
tobec9563
Comparemchandschuh approved these changesAug 24, 2018
Merged
4 tasks
Martin-Molinero pushed a commit that referenced this pull requestApr 26, 2022
Reflect PR#8 MISSING CONVERTER.CS L516-528 ChangesReflect PR#14Reflect PR#15Reflect PR#19Reflect PR#25Reflect PR#34Reflect PR#35Implement List Conversion, Reflect PR#37 TestsReflect PR#38 Partial: Assembly Manager ImprovementsReflect PR#38Reflect PR#42 KeyValuePairEnumerableObjectReflect PR#10 Runtime DecimalTypeAdd TimeDelta and DateTime testsFix DecimalConversion test for float conversionConverter mod tweaksAdjust a few broken PyTestsUse _pydecimal to not interfere with Lean/decimal.pyAdd MethodBinder testsMethodBinder implicit resolutionFix bad cherry pickRefactoring precedence resolutionDeal with operator bindingFix `TestNoOverloadException` unit testFix for DomainReload testsAdd InEquality Operator TestDont PyObjects precedence in Operator methodsRevert "Merge pull requestpythonnet#1240 from danabr/auto-cast-ret-val-to-interface"This reverts commit50d947f, reversingchanges made tod44f1da.Fix Primitive Conversion to IntPost rebase fixAdd PrimitiveIntConversion testAdd test for interface derived classesAdd to Authors.mdLoad in current directory into Python PathInclude Python Lib in packageUpdate as QuantConnect.PythonNet; include console exe in packageDrop MaybeType from ClassManager for performancePackage nPython from same configurationAddress KWargs and Params; also cleanupAdd unit testsAdd pytest params unit test to testrunnerRemove testing case from TestRuntime.csFix HandleParamsArrayTest caseVersion bumpUpdate QC TestsRefactor Params FixFix assembly infoHandle breaking PyTestsCleanupOptimize Params HandlingFirst reflection improvementsAdd TypeAccessor improvements and a bunch more testsMore improvementsBump version to 2.0.2Revert ClassManager changesRemove readonlyReplace FastMember with FasterflectAdd global MemberGetter/MemberSetter cacheMinor changesMake Fasterflect work with all regression testsFix performance regressionsRevert accidental pythonnet/runtime/.gitkeep removalHandle sending a python list to an enumerable expecting method- Converter with handle sending a python List to a method expecting a csharp enumerable. Adding unit testBump version to 2.0.3Update to net5.0- Updating all projects to target net.50- Remove domain test since it's not supported in net5.0Bump pythonNet version 2.0.4Add reproducing testApply fixCatch implicit conversion throwCleanup solutionCleanup V2Assert Error messageSmall performance improvementDrop print statement from unit testBump version to 2.0.5Bump references to new versionFix for methods with different numerical precision overloads - Fix for methods with different numerical precision overloads. Method precedence will give higher priority to higher resolution numerical arguments. Adding unit testVersion bump to 2.0.6KeyValuePair conversion and performance- Improve DateTime conversion performance- Add support for KeyValuePair conversions- Minor improvements for convertions and method binderTypeManager and decimal improvementsReduce unrequired castingVersion bump to 2.0.7Apply fixesProject fix for linux systemsAdd unit testConverter cleanupMore adjustments and fixesAdd additional Py test & cleanupUse the generic match when others failAdd test for non-generic choiceAddress reviewCleanupVersion bump 2.0.8Add performance test, also add cachingMake Cache static to apply to all bindersMake adjustments from testingAdd test where overload exists with an already typed generic parameteruse `ContainsGenericParameters` to check for unassigned genericsImplement fixAdd accompanying testAdd additional testsFix minor issue with py Date -> DateTimeRefactor solution, use margs directly convert in ResolveGenericMethodVersion Bump 2.0.9Add missing exception clearing. Adding unit testVersion bump 2.0.10Handle readonly conversion to list. Adding unit testsBump version to 2.0.11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DECREF'ing datetime timezone argument when DateTimeKind is Unspecified was causing
Fatal Python error: deallocating None
because the object was set toRuntime.PyNone
.Fixed the input to datetime constructor as we were passing milliseconds, where it should be microseconds.