Commit8126db6

authored and

committed

fixed crash due to unnecessary decref of a borrowed reference in params array handling (pythonnet#1163)

1 parent034330f commit8126db6Copy full SHA for 8126db6

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -412,7 +412,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`412`	`412`	`staticIntPtrHandleParamsArray(IntPtrargs,intarrayStart,intpyArgCount,outboolisNewReference)`
`413`	`413`	`{`
`414`	`414`	`isNewReference=false;`
`415`		`-IntPtrop;`
	`415`	`+IntPtrop;`
`416`	`416`	`// for a params method, we may have a sequence or single/multiple items`
`417`	`417`	`// here we look to see if the item at the paramIndex is there or not`
`418`	`418`	`// and then if it is a sequence itself.`
`@@ -430,10 +430,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out`
`430`	`430`	`{`
`431`	`431`	`isNewReference=true;`
`432`	`432`	`op=Runtime.PyTuple_GetSlice(args,arrayStart,pyArgCount);`
`433`		`-if(item!=IntPtr.Zero)`
`434`		`-{`
`435`		`-Runtime.XDecref(item);`
`436`		`-}`
`437`	`433`	`}`
`438`	`434`	`}`
`439`	`435`	`else`

Comments

(0)