Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

fix(modal): fakeModal props not working with alert modal#1852

Merged
RemiBonnet merged 1 commit intostagingfromfix/fakeModal-props-QOV-108
Mar 24, 2025

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/c/projects/QOV/boards/56?selectedIssue=QOV-108

PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
MemberAuthor

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

CommandBlueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfecstorybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425staging
/qovery preview {all|UUID1,UUID2,...}To preview multiple environments

This comment has been generated fromQovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@RemiBonnetRemiBonnet marked this pull request as ready for reviewMarch 24, 2025 03:46
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitb65e430.

CommandStatusDurationResult
nx affected --target=lint --parallel=3✅ Succeeded4m 21sView ↗
nx affected --target=test --parallel=3 --config...✅ Succeeded4m 20sView ↗
nx affected --target=build --parallel=3✅ Succeeded2m 24sView ↗
nx-cloud record -- npx nx format:check✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-03-24 03:52:19 UTC

@codecovCodecov
Copy link

codecovbot commentedMar 24, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is33.33333% with8 lines in your changes missing coverage. Please review.

Project coverage is 53.45%. Comparing base(4007e99) to head(b65e430).
Report is 1 commits behind head on staging.

Files with missing linesPatch %Lines
libs/shared/ui/src/lib/components/modal/modal.tsx36.36%6 Missing and 1 partial⚠️
...re/page-organization-helm-repositories-feature.tsx0.00%1 Missing⚠️
Additional details and impacted files
@@             Coverage Diff             @@##           staging    #1852      +/-   ##===========================================- Coverage    58.66%   53.45%   -5.21%===========================================  Files          315      972     +657       Lines         5668    13748    +8080       Branches      1720     4031    +2311     ===========================================+ Hits          3325     7349    +4024- Misses        1734     5024    +3290- Partials       609     1375     +766
FlagCoverage Δ
unittests53.45% <33.33%> (-5.21%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnetRemiBonnet merged commit8637998 intostagingMar 24, 2025
10 of 11 checks passed
@RemiBonnetRemiBonnet deleted the fix/fakeModal-props-QOV-108 branchMarch 24, 2025 06:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@RemiBonnet
[8]ページ先頭
©2009-2025 Movatter.jp