Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add tanstack/router#1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ctjhoa wants to merge9 commits intostaging
base:staging
Choose a base branch
Loading
fromreact_router
Draft

chore: add tanstack/router#1141

ctjhoa wants to merge9 commits intostagingfromreact_router

Conversation

ctjhoa
Copy link
Contributor

@ctjhoactjhoa commentedJan 22, 2024•
edited
Loading

What does this PR do?

This PR adds@tanstack/router in conjunction withreact-router-dom.

This PR is currently blocked bythis bug

Current state:

  • react-router -> tanstack-router = OK
  • tanstack-router -> react-router = KO

There is an issue to migrate incrementally from react-router to tanstack/router.
When doing transitions like react-router -> tanstack/router -> react-router, tanstack router go into thedefaultNotFoundComponent state during the last transition.
There don't seems to be a way to reset that internal state in tanstack router, so tanstack router is stuck on login page.

RemiBonnet reacted with thumbs up emoji
@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

CommandBlueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfecstorybook
/qovery preview 28102cd2-684e-4ecb-a4f7-2f37f653b027my-helm-env
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425staging
/qovery preview {all|UUID1,UUID2,...}To preview multiple environments

This comment has been generated fromQovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@RemiBonnet
Copy link
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉[PR] my-env - chore: add tanstack/router - 2024-01-22T13:21:44Z

Another comment will be posted when deployments are terminated

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJan 22, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit891ff45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 fromNxCloud.

@RemiBonnet
Copy link
Member

Qovery Preview

Your preview environment failed to be deployed !
Click on the link below to check the deployment logs.
👉[PR] my-env - chore: add tanstack/router - 2024-01-22T13:21:44Z

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ctjhoa@RemiBonnet
[8]ページ先頭
©2009-2025 Movatter.jp