Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Investigate/fixtest_cancel_running_job() intest_job.py#1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kt474 merged 9 commits intoQiskit:mainfromsim-eng-ii:issue-1019-bug-fix
Aug 28, 2023

Conversation

@sim-eng-ii
Copy link

@sim-eng-iisim-eng-ii commentedAug 19, 2023
edited
Loading

Summary

This PR addresses the issue described inIssue #1019,

Changes Made

- Modified thecancel method inruntime_job.py to handle status codes 409 and 204 as cases where job cancellation cannot be performed due to specific conditions. This ensures that the client-side status accurately reflects the server-side status.

  • Updated thetest_cancel_job_running function to wait for the server-side status update after cancellation before performing assertions. This change ensures that the test accurately reflects the behaviour of cancelling a running job.

Fixes:

@CLAassistant
Copy link

CLAassistant commentedAug 19, 2023
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sim-eng-ii
Copy link
Author

sim-eng-ii commentedAug 20, 2023
edited
Loading

@kt474 I will fix the release notes as well

@coveralls
Copy link

Pull Request Test Coverage Report forBuild 5918090939

  • 0 of0 changed or added relevant lines in0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at74.058%

TotalsCoverage Status
Change from baseBuild 5906160217:0.0%
Covered Lines:2458
Relevant Lines:3319

💛 -Coveralls

Copy link
Member

@kt474kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking care of this @robotAstray! I think there is still an issue with thecancel() method itself but that can be taken care of in a separate PR

#1038

sim-eng-ii reacted with hooray emoji
@kt474kt474 merged commitb9b3fda intoQiskit:mainAug 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kt474kt474kt474 approved these changes

+1 more reviewer

@merav-aharonimerav-aharonimerav-aharoni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sim-eng-ii@CLAassistant@coveralls@kt474@merav-aharoni

[8]ページ先頭

©2009-2025 Movatter.jp