- Notifications
You must be signed in to change notification settings - Fork193
Investigate/fixtest_cancel_running_job() intest_job.py#1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedAug 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
…ob.py` for semplicity
Uh oh!
There was an error while loading.Please reload this page.
sim-eng-ii commentedAug 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@kt474 I will fix the release notes as well |
Uh oh!
There was an error while loading.Please reload this page.
coveralls commentedAug 21, 2023
Pull Request Test Coverage Report forBuild 5918090939
💛 -Coveralls |
kt474 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for taking care of this @robotAstray! I think there is still an issue with thecancel() method itself but that can be taken care of in a separate PR
Uh oh!
There was an error while loading.Please reload this page.
Summary
This PR addresses the issue described inIssue #1019,
Changes Made
- Modified thecancelmethod inruntime_job.pyto handle status codes 409 and 204 as cases where job cancellation cannot be performed due to specific conditions. This ensures that the client-side status accurately reflects the server-side status.test_cancel_job_runningfunction to wait for the server-side status update after cancellation before performing assertions. This change ensures that the test accurately reflects the behaviour of cancelling a running job.Fixes:
Fixes a race condition in the function
test_cancel_running_job()intest_job()where job cancellationcannot be performed due to specific conditions. Refer toInvestigate/fix
test_cancel_running_job#1019 for more details.