Commita237cf2

committed

Add alternate implementation of forEach

1 parentaf5a639 commita237cf2Copy full SHA for a237cf2

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,6 @@ describe("Map with two objects", () => {`
`250`	`250`	`it("Map forEach is called twice",()=>{`
`251`	`251`	`letcount=0;`
`252`	`252`	`arrayStringMap.forEach((value,key,map)=>{`
`253`		`-count++;`
`254`	`253`	`assert(map===arrayStringMap,"Map is arrayStringMap");`
`255`	`254`	`if(count===0){`
`256`	`255`	`assert(key===sampleArray1,"Key is sampleArray1");`
`@@ -260,6 +259,7 @@ describe("Map with two objects", () => {`
`260`	`259`	`assert(key===sampleArray3,"Key is sampleArray3");`
`261`	`260`	`assert(value===sampleValue2,"Value is sampleValue2");`
`262`	`261`	`}`
	`262`	`+count++;`
`263`	`263`	`});`
`264`	`264`	`assert(count===2,"ForEach is called twice");`
`265`	`265`	`})`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,11 +51,9 @@ export default class ArrayStringMap<K extends any[], V> implements Map<K, V> {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`forEach(callbackfn:(value:V,key:K,map:ArrayStringMap<K,V>)=>void,thisArg?:any):void{`
`54`		`-this._converterInfo.forEach((value,key)=>{`
`55`		`-// TypeScript complains that this will be undefined, but the items in`
`56`		-// `this._converterInfo` and `this._map` will always be defined in each other.
`57`		`-returncallbackfn(this._map.get(key)!,value,thisArg);`
`58`		`-});`
	`54`	`+for(const[key,value]ofthis.entries()){`
	`55`	`+callbackfn.call(thisArg,value,key,this);`
	`56`	`+}`
`59`	`57`	`}`
`60`	`58`
`61`	`59`	`get(key:K):V\|undefined{`

Comments

(0)