Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add sidepath name fallback using is_sidepath:of:name and street:name tags#7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
afarber wants to merge2 commits intoProject-OSRM:master
base:master
Choose a base branch
Loading
fromafarber:7259-fallback-name

Conversation

@afarber
Copy link
Contributor

Issue

Fixes#7259

When sidewalks and cycleways are mapped as separate ways in OSM, they often lack aname tag. This results in unhelpful
navigation instructions like "Turn right, walk 150 m" instead of "Turn right onto Main Street, walk 150 m".

This PR adds support for fallback name tags that OSM mappers use to associate sidewalks with their adjacent streets:

  • is_sidepath:of:name (~15,500 uses in OSM)
  • street:name (~9,100 uses in OSM)

The fallback only applies when:

  1. The way has noname tag
  2. The highway type isfootway,cycleway, orpath
  3. The way is marked as a sidepath viafootway=sidewalk,cycleway=sidepath, oris_sidepath=yes

Car routing is unaffected because the fallback requires the highway type to befootway,cycleway, orpath. Even if
someone mistakenly addsfootway=sidewalk to ahighway=primary, the fallback will not trigger since it checks the
highway type first.

Tests added

Foot profile (features/foot/sidepath_names.feature):

  • Useis_sidepath:of:name for unnamed sidewalk
  • Usestreet:name for unnamed sidewalk
  • is_sidepath:of:name takes priority overstreet:name
  • Explicitname tag takes priority over fallback
  • Useis_sidepath=yes withstreet:name
  • No fallback without sidepath marker

Bicycle profile (features/bicycle/sidepath_names.feature):

  • Useis_sidepath:of:name for cycleway sidepath
  • Usestreet:name for cycleway sidepath
  • Explicit name takes priority
  • Useis_sidepath=yes withis_sidepath:of:name
  • No fallback without sidepath marker

Car profile (features/car/sidepath_names.feature):

  • Does not use sidepath name fallback on roads
  • Does not pick upis_sidepath:of:name on roads
  • Sidepath markers do not affect car roads

Tasklist

Requirements / Relations

None

jarek reacted with heart emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use more tags to determine names of footways and sidepaths

1 participant

@afarber

[8]ページ先頭

©2009-2025 Movatter.jp