- Notifications
You must be signed in to change notification settings - Fork3.8k
Fix max excludate classses to 7, not 8#7282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
frodrigo wants to merge1 commit intoProject-OSRM:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+2 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…_CLASS_INDEX aka MAX_EXCLUDABLE_CLASSES - 1
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#7280
Issue
MAX_EXCLUDABLE_CLASSESis set 8, and then the number of exclusion sets is checked withexcludable_classes.size() > MAX_EXCLUDABLE_CLASSESto raise error.But when we try de define 8 exclusion classes, the last one is not usable at runtime. The API return for this last exclusion
{"message":"Exclude flag combination is not supported.","code":"InvalidValue"}Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?