Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade FlatBuffers to 25.9.23 and use TypeScript workflow#7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
afarber wants to merge10 commits intoProject-OSRM:master
base:master
Choose a base branch
Loading
fromafarber:7235-upgrade-flatbuffers

Conversation

@afarber
Copy link
Contributor

@afarberafarber commentedNov 15, 2025
edited
Loading

Fix#7235 by:

  • Upgrade FlatBuffers from 24.3.25 to 25.9.23
  • Switch from "flatc --js" to "flatc --ts" with transpilation to Javascript
  • Update the import paths in test files

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarberafarberforce-pushed the7235-upgrade-flatbuffers branch from1449084 to03abe0aCompareNovember 15, 2025 15:57
@afarber
Copy link
ContributorAuthor

Hi@SiarheiFedartsou, hi@DennisOSRM please review my PR.

flatc does not support generating Javascript files anymore, so I transpile Typescript to Javascript.

@afarberafarber changed the titleUpgrade FlatBuffers to 25.9.23 and use Typescript workflowUpgrade FlatBuffers to 25.9.23 and use TypeScript workflowNov 16, 2025
@afarber
Copy link
ContributorAuthor

Hi@DennisOSRM and@SiarheiFedartsou please review my PR.

The PR modifies many files in the third_party/flatbuffers folder.

To verify, that I have not introduced any "trojan horses", you could run:

  git clone --depth 1 --branch v25.9.23 https://github.com/google/flatbuffers.git /tmp/flatbuffers-official  for dir in include src CMakeLists.txt; do    echo "=== Comparing $dir ==="    diff -r "third_party/flatbuffers/$dir" "/tmp/flatbuffers-official/$dir" \      --exclude='*.o' --exclude='*.so' --exclude='CMakeFiles' \      --exclude='*.cmake' --exclude='Makefile' 2>/dev/null || echo "No differences"  done

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade FlatBuffers from 24.3.25 to 25.9.23

1 participant

@afarber

[8]ページ先頭

©2009-2025 Movatter.jp