- Notifications
You must be signed in to change notification settings - Fork3.8k
#7047: Nearest api returning node with id 0#7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
#7047: Nearest api returning node with id 0#7048
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR seems to be stale. Is it still relevant? |
moboge commentedApr 7, 2025
@jcoupey any idea on when this PR can be merged into the master? |
DennisOSRM commentedApr 7, 2025
i have this on my plate for the coming week. |
DennisOSRM commentedApr 16, 2025
Change looks good to me. What we'd need is a test case that fails without this change and succeeds with it. |
| forward_geometry(phantom_node.fwd_segment_position -1)); | ||
| from_node =static_cast<std::uint64_t>(osm_node_id); | ||
| } | ||
| elseif (phantom_node.fwd_segment_position ==0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wouldn't this be more readable?
else if (phantom_node.forward_segment_id.enabled && phantom_node.fwd_segment_position == 0){ // At the very beginning of a one-way forward geometry. // Segment runs from the first OSM node to the second OSM node. // We require at least 2 nodes in forward_geometry to form a valid edge. BOOST_ASSERT(forward_geometry.size() >= 2); auto from_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[0]); auto to_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[1]); from_node = static_cast<std::uint64_t>(from_osm_node); to_node = static_cast<std::uint64_t>(to_osm_node);}
Uh oh!
There was an error while loading.Please reload this page.
Issue
Bug: Nearest api returning node with id 0
Tasklist
Snapshot of bug fix
FYI@jcoupey