Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

uncomment "cyclability" weight name#7043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
szymon-szym wants to merge2 commits intoProject-OSRM:master
base:master
Choose a base branch
Loading
fromszymon-szym:weight-name-bicycle-profile

Conversation

@szymon-szym
Copy link

@szymon-szymszymon-szym commentedSep 29, 2024•
edited
Loading

Issue

It looks like inprofile/bicycle.lua theweight_name in properties was unintentionally commented out

Without it set tocyclability thesafety_check is committed when using this profile. Turns' weights are also calculated differently

Tasklist

Requirements / Relations

@frodrigo
Copy link
Member

From the introduction of the conceptweight in bicycle profile, it always beduration as default.

279f8aabfb#diff-c4b120b8978b0193746a4accb230bf085b89bca0fdda9f17920e056ddaee820fR58

I see this PR as a possible breaking change.

Nevertheless can can still usecyclability on you side if you prefer it.

@github-actions
Copy link

This PR seems to be stale. Is it still relevant?

@TheMarex
Copy link
Member

For context: This was not chosen as the default because it roughly x1.5 the memory usage since you need separate weight and duration values.

@github-actionsgithub-actionsbot removed the Stale labelOct 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@kdziurmankdziurmankdziurman approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szymon-szym@frodrigo@TheMarex@kdziurman
[8]ページ先頭
©2009-2025 Movatter.jp