- Notifications
You must be signed in to change notification settings - Fork3.8k
Upgrade clang-format to version 15#6859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Version 14 is the version available on ubuntu-latest in Github actions
| -name:Prepare environment | ||
| run:| | ||
| npm ci --ignore-scripts | ||
| clang-format-10 --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems ubuntu-22.04 has clang-format-15. May be worth updating to it as we have to reformat a lot of files anyway?https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
Btw 24.04 seems to be already available as well…
DennisOSRMMay 5, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh great, then I'll amend this PR to go straight to 24.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I made this conclusion from existence ofhttps://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md, so not sure it is available in reality :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems that 24.04 based runners are not available yet. Sticking to 22.04 for now.
Version 14 is the version available on ubuntu-latest in Github actions