Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix 32 bit CI builds#6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mjjbell merged 2 commits intoProject-OSRM:masterfrommjjbell:mbell/fix_i686_build
Dec 22, 2021
Merged

Conversation

@mjjbell
Copy link
Member

@mjjbellmjjbell commentedDec 11, 2021•
edited
Loading

Issue

This PR fixes two issues

  1. Mason CMake was not being installed correctly due to a typo in the Github Actions script.
    Once fixed, it also uncovers another problem. The version of Mason CMake requires libssl 1.0 as a dependency, whilst the Ubuntu Focal runners are on the newer libssl 1.1. Therefore, we also bump the version to3.21.2 on CI.

  2. A recent change to the Ubuntu Focal CI worker - possibly due to libexpat-dev being installed by default - leads to the 32-bit expat library to not be found by CMake (example).FindPackage(EXPAT) finds the library viapkg-config, so the fix is to explicitly include the i386 pkgconfig directory in thePKG_CONFIG_PATH environment variable list.

Tasklist

Requirements / Relations

Fixes#6165

During the CI migration to Github Actions, a bug was introducedsuch that Mason CMake is not being added to the PATH environmentvariable correctly, so it defaults to the CMake installed in theOS environment.Simple fixing the typo fails as the Mason CMake version requireslibssl 1.0 as a dependency, whilst the Ubuntu Focal runners areon the newer libssl 1.1. Therefore, we also bump the MasonCMake version to 3.21.2.
A recent change to the Ubuntu Focal CI worker - either a CMake upgrade,or default installation of the libexpat-dev library - leads to the32-bit expat library to not be found by CMake.FindPackage(EXPAT) finds the library via pkg-config, so the fix isto explicitly include the i386 pkg-config directory in thePKG_CONFIG_PATH environment variable list.
@mjjbell
Copy link
MemberAuthor

PTAL@danpat@TheMarex . Needed to unblock CI

@mjjbellmjjbell merged commit2c81083 intoProject-OSRM:masterDec 22, 2021
@mjjbellmjjbell deleted the mbell/fix_i686_build branchDecember 22, 2021 23:27
datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull requestDec 18, 2022
v5.27.0- Changes from 5.26.0    - API:      - ADDED: Add Flatbuffers support to NodeJS bindings. [Project-OSRM#6338](Project-OSRM#6338)      - CHANGED: Add `data_version` field to responses of all services. [Project-OSRM#5387](Project-OSRM#5387)      - FIXED: Use Boost.Beast to parse HTTP request. [Project-OSRM#6294](Project-OSRM#6294)      - FIXED: Fix inefficient osrm-routed connection handling [Project-OSRM#6113](https://gihub.com/Project-OSRM/osrm-backend/pull/6113)      - FIXED: Fix HTTP compression precedence [Project-OSRM#6113](Project-OSRM#6113)    - NodeJS:      - FIXED: Support `skip_waypoints` in Node bindings [Project-OSRM#6060](Project-OSRM#6060)    - Misc:      - ADDED: conanbuildinfo.json for easy reading of dependencies [Project-OSRM#6388](Project-OSRM#6388)      - CHANGED: Improve performance of JSON rendering. Fix undefined behaviour in JSON numbers formatting. [Project-OSRM#6380](Project-OSRM#6380)      - ADDED: Add timestamps for logs. [Project-OSRM#6375](Project-OSRM#6375)      - CHANGED: Improve performance of map matching via getPathDistance optimization. [Project-OSRM#6378](Project-OSRM#6378)      - CHANGED: Optimize RestrictionParser performance. [Project-OSRM#6344](Project-OSRM#6344)      - ADDED: Support floats for speed value in traffic updates CSV. [Project-OSRM#6327](Project-OSRM#6327)      - CHANGED: Use Lua 5.4 in Docker image. [Project-OSRM#6346](Project-OSRM#6346)      - CHANGED: Remove redundant nullptr check. [Project-OSRM#6326](Project-OSRM#6326)      - CHANGED: missing files list is included in exception message. [Project-OSRM#5360](Project-OSRM#5360)      - CHANGED: Do not use deprecated Callback::Call overload in Node bindings. [Project-OSRM#6318](Project-OSRM#6318)      - FIXED: Fix distance calculation consistency. [Project-OSRM#6315](Project-OSRM#6315)      - FIXED: Fix performance issue after migration to sol2 3.3.0. [Project-OSRM#6304](Project-OSRM#6304)      - CHANGED: Pass osm_node_ids by reference in osrm::updater::Updater class. [Project-OSRM#6298](Project-OSRM#6298)      - FIXED: Fix bug with reading Set values from Lua scripts. [Project-OSRM#6285](Project-OSRM#6285)      - FIXED: Bug in bicycle profile that caused exceptions if there is a highway=bicycle in the data. [Project-OSRM#6296](Project-OSRM#6296)      - FIXED: Internal refactoring of identifier types used in data facade [Project-OSRM#6044](Project-OSRM#6044)      - CHANGED: Update docs to reflect recent build and dependency changes [Project-OSRM#6383](Project-OSRM#6383)    - Build:      - REMOVED: Get rid of Mason. [Project-OSRM#6387](Project-OSRM#6387)      - CHANGED: Use clang-format from CI base image. [Project-OSRM#6391](Project-OSRM#6391)      - ADDED: Build Node bindings on Windows. [Project-OSRM#6334](Project-OSRM#6334)      - ADDED: Configure cross-compilation for Apple Silicon. [Project-OSRM#6360](Project-OSRM#6360)      - CHANGED: Use apt-get to install Clang on CI. [Project-OSRM#6345](Project-OSRM#6345)      - CHANGED: Fix TBB in case of Conan + NodeJS build. [Project-OSRM#6333](Project-OSRM#6333)      - CHANGED: Migrate to modern TBB version. [Project-OSRM#6300](Project-OSRM#6300)      - CHANGED: Enable performance-move-const-arg clang-tidy check. [Project-OSRM#6319](Project-OSRM#6319)      - CHANGED: Use the latest node on CI. [Project-OSRM#6317](Project-OSRM#6317)      - CHANGED: Migrate Windows CI to GitHub Actions. [Project-OSRM#6312](Project-OSRM#6312)      - ADDED: Add smoke test for Docker image. [Project-OSRM#6313](Project-OSRM#6313)      - CHANGED: Update libosmium to version 2.18.0. [Project-OSRM#6303](Project-OSRM#6303)      - CHANGED: Remove EXACT from find_package if using Conan. [Project-OSRM#6299](Project-OSRM#6299)      - CHANGED: Configure Undefined Behaviour Sanitizer. [Project-OSRM#6290](Project-OSRM#6290)      - CHANGED: Use Conan instead of Mason to install code dependencies. [Project-OSRM#6284](Project-OSRM#6284)      - CHANGED: Migrate to C++17. Update sol2 to 3.3.0. [Project-OSRM#6279](Project-OSRM#6279)      - CHANGED: Update macOS CI image to macos-11. [Project-OSRM#6286](Project-OSRM#6286)      - CHANGED: Enable even more clang-tidy checks. [Project-OSRM#6273](Project-OSRM#6273)      - CHANGED: Configure CMake to not build flatbuffers tests and samples. [Project-OSRM#6274](Project-OSRM#6274)      - CHANGED: Enable more clang-tidy checks. [Project-OSRM#6270](Project-OSRM#6270)      - CHANGED: Configure clang-tidy job on CI. [Project-OSRM#6261](Project-OSRM#6261)      - CHANGED: Use Github Actions for building container images [Project-OSRM#6138](Project-OSRM#6138)      - CHANGED: Upgrade Boost dependency to 1.70 [Project-OSRM#6113](Project-OSRM#6113)      - CHANGED: Upgrade Ubuntu CI builds to 20.04  [Project-OSRM#6119](Project-OSRM#6119)      - CHANGED: Make building osrm-routed optional [Project-OSRM#6144](Project-OSRM#6144)      - FIXED: Run all unit tests in CI [Project-OSRM#5248](Project-OSRM#5248)      - FIXED: Fix installation of Mason CMake and 32 bit CI build [Project-OSRM#6170](Project-OSRM#6170)      - FIXED: Fixed Node docs generation check in CI. [Project-OSRM#6058](Project-OSRM#6058)      - CHANGED: Docker build, enabled arm64 build layer [Project-OSRM#6172](Project-OSRM#6172)      - CHANGED: Docker build, enabled apt-get update/install caching in separate layer for build phase [Project-OSRM#6175](Project-OSRM#6175)      - FIXED: Bump CI complete meta job to ubuntu-20.04 [Project-OSRM#6323](Project-OSRM#6323)      - CHANGED: Node packages are now scoped by@Project-OSRM [Project-OSRM#6386](Project-OSRM#6386)    - Routing:      - CHANGED: Lazily generate optional route path data [Project-OSRM#6045](Project-OSRM#6045)      - FIXED: Completed support for no_entry and no_exit turn restrictions. [Project-OSRM#5988](Project-OSRM#5988)      - ADDED: Add support for non-round-trips with a single fixed endpoint. [Project-OSRM#6050](Project-OSRM#6050)      - FIXED: Improvements to maneuver override processing [Project-OSRM#6125](Project-OSRM#6125)      - ADDED: Support snapping to multiple ways at an input location. [Project-OSRM#5953](Project-OSRM#5953)      - FIXED: Fix snapping target locations to ways used in turn restrictions. [Project-OSRM#6339](Project-OSRM#6339)      - ADDED: Support OSM traffic signal directions. [Project-OSRM#6153](Project-OSRM#6153)      - FIXED: Ensure u-turn exists in intersection view. [Project-OSRM#6376](Project-OSRM#6376)      - FIXED: Gracefully handle no-turn intersections in guidance processing. [Project-OSRM#6382](Project-OSRM#6382)    - Profile:      - CHANGED: Bicycle surface speeds [Project-OSRM#6212](Project-OSRM#6212)    - Tools:      - CHANGED: Do not generate intermediate .osrm file in osrm-extract. [Project-OSRM#6354](Project-OSRM#6354)
datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull requestDec 18, 2022
v5.27.0- Changes from 5.26.0    - API:      - ADDED: Add Flatbuffers support to NodeJS bindings. [Project-OSRM#6338](Project-OSRM#6338)      - CHANGED: Add `data_version` field to responses of all services. [Project-OSRM#5387](Project-OSRM#5387)      - FIXED: Use Boost.Beast to parse HTTP request. [Project-OSRM#6294](Project-OSRM#6294)      - FIXED: Fix inefficient osrm-routed connection handling [Project-OSRM#6113](https://gihub.com/Project-OSRM/osrm-backend/pull/6113)      - FIXED: Fix HTTP compression precedence [Project-OSRM#6113](Project-OSRM#6113)    - NodeJS:      - FIXED: Support `skip_waypoints` in Node bindings [Project-OSRM#6060](Project-OSRM#6060)    - Misc:      - ADDED: conanbuildinfo.json for easy reading of dependencies [Project-OSRM#6388](Project-OSRM#6388)      - CHANGED: Improve performance of JSON rendering. Fix undefined behaviour in JSON numbers formatting. [Project-OSRM#6380](Project-OSRM#6380)      - ADDED: Add timestamps for logs. [Project-OSRM#6375](Project-OSRM#6375)      - CHANGED: Improve performance of map matching via getPathDistance optimization. [Project-OSRM#6378](Project-OSRM#6378)      - CHANGED: Optimize RestrictionParser performance. [Project-OSRM#6344](Project-OSRM#6344)      - ADDED: Support floats for speed value in traffic updates CSV. [Project-OSRM#6327](Project-OSRM#6327)      - CHANGED: Use Lua 5.4 in Docker image. [Project-OSRM#6346](Project-OSRM#6346)      - CHANGED: Remove redundant nullptr check. [Project-OSRM#6326](Project-OSRM#6326)      - CHANGED: missing files list is included in exception message. [Project-OSRM#5360](Project-OSRM#5360)      - CHANGED: Do not use deprecated Callback::Call overload in Node bindings. [Project-OSRM#6318](Project-OSRM#6318)      - FIXED: Fix distance calculation consistency. [Project-OSRM#6315](Project-OSRM#6315)      - FIXED: Fix performance issue after migration to sol2 3.3.0. [Project-OSRM#6304](Project-OSRM#6304)      - CHANGED: Pass osm_node_ids by reference in osrm::updater::Updater class. [Project-OSRM#6298](Project-OSRM#6298)      - FIXED: Fix bug with reading Set values from Lua scripts. [Project-OSRM#6285](Project-OSRM#6285)      - FIXED: Bug in bicycle profile that caused exceptions if there is a highway=bicycle in the data. [Project-OSRM#6296](Project-OSRM#6296)      - FIXED: Internal refactoring of identifier types used in data facade [Project-OSRM#6044](Project-OSRM#6044)      - CHANGED: Update docs to reflect recent build and dependency changes [Project-OSRM#6383](Project-OSRM#6383)    - Build:      - REMOVED: Get rid of Mason. [Project-OSRM#6387](Project-OSRM#6387)      - CHANGED: Use clang-format from CI base image. [Project-OSRM#6391](Project-OSRM#6391)      - ADDED: Build Node bindings on Windows. [Project-OSRM#6334](Project-OSRM#6334)      - ADDED: Configure cross-compilation for Apple Silicon. [Project-OSRM#6360](Project-OSRM#6360)      - CHANGED: Use apt-get to install Clang on CI. [Project-OSRM#6345](Project-OSRM#6345)      - CHANGED: Fix TBB in case of Conan + NodeJS build. [Project-OSRM#6333](Project-OSRM#6333)      - CHANGED: Migrate to modern TBB version. [Project-OSRM#6300](Project-OSRM#6300)      - CHANGED: Enable performance-move-const-arg clang-tidy check. [Project-OSRM#6319](Project-OSRM#6319)      - CHANGED: Use the latest node on CI. [Project-OSRM#6317](Project-OSRM#6317)      - CHANGED: Migrate Windows CI to GitHub Actions. [Project-OSRM#6312](Project-OSRM#6312)      - ADDED: Add smoke test for Docker image. [Project-OSRM#6313](Project-OSRM#6313)      - CHANGED: Update libosmium to version 2.18.0. [Project-OSRM#6303](Project-OSRM#6303)      - CHANGED: Remove EXACT from find_package if using Conan. [Project-OSRM#6299](Project-OSRM#6299)      - CHANGED: Configure Undefined Behaviour Sanitizer. [Project-OSRM#6290](Project-OSRM#6290)      - CHANGED: Use Conan instead of Mason to install code dependencies. [Project-OSRM#6284](Project-OSRM#6284)      - CHANGED: Migrate to C++17. Update sol2 to 3.3.0. [Project-OSRM#6279](Project-OSRM#6279)      - CHANGED: Update macOS CI image to macos-11. [Project-OSRM#6286](Project-OSRM#6286)      - CHANGED: Enable even more clang-tidy checks. [Project-OSRM#6273](Project-OSRM#6273)      - CHANGED: Configure CMake to not build flatbuffers tests and samples. [Project-OSRM#6274](Project-OSRM#6274)      - CHANGED: Enable more clang-tidy checks. [Project-OSRM#6270](Project-OSRM#6270)      - CHANGED: Configure clang-tidy job on CI. [Project-OSRM#6261](Project-OSRM#6261)      - CHANGED: Use Github Actions for building container images [Project-OSRM#6138](Project-OSRM#6138)      - CHANGED: Upgrade Boost dependency to 1.70 [Project-OSRM#6113](Project-OSRM#6113)      - CHANGED: Upgrade Ubuntu CI builds to 20.04  [Project-OSRM#6119](Project-OSRM#6119)      - CHANGED: Make building osrm-routed optional [Project-OSRM#6144](Project-OSRM#6144)      - FIXED: Run all unit tests in CI [Project-OSRM#5248](Project-OSRM#5248)      - FIXED: Fix installation of Mason CMake and 32 bit CI build [Project-OSRM#6170](Project-OSRM#6170)      - FIXED: Fixed Node docs generation check in CI. [Project-OSRM#6058](Project-OSRM#6058)      - CHANGED: Docker build, enabled arm64 build layer [Project-OSRM#6172](Project-OSRM#6172)      - CHANGED: Docker build, enabled apt-get update/install caching in separate layer for build phase [Project-OSRM#6175](Project-OSRM#6175)      - FIXED: Bump CI complete meta job to ubuntu-20.04 [Project-OSRM#6323](Project-OSRM#6323)      - CHANGED: Node packages are now scoped by@Project-OSRM [Project-OSRM#6386](Project-OSRM#6386)    - Routing:      - CHANGED: Lazily generate optional route path data [Project-OSRM#6045](Project-OSRM#6045)      - FIXED: Completed support for no_entry and no_exit turn restrictions. [Project-OSRM#5988](Project-OSRM#5988)      - ADDED: Add support for non-round-trips with a single fixed endpoint. [Project-OSRM#6050](Project-OSRM#6050)      - FIXED: Improvements to maneuver override processing [Project-OSRM#6125](Project-OSRM#6125)      - ADDED: Support snapping to multiple ways at an input location. [Project-OSRM#5953](Project-OSRM#5953)      - FIXED: Fix snapping target locations to ways used in turn restrictions. [Project-OSRM#6339](Project-OSRM#6339)      - ADDED: Support OSM traffic signal directions. [Project-OSRM#6153](Project-OSRM#6153)      - FIXED: Ensure u-turn exists in intersection view. [Project-OSRM#6376](Project-OSRM#6376)      - FIXED: Gracefully handle no-turn intersections in guidance processing. [Project-OSRM#6382](Project-OSRM#6382)    - Profile:      - CHANGED: Bicycle surface speeds [Project-OSRM#6212](Project-OSRM#6212)    - Tools:      - CHANGED: Do not generate intermediate .osrm file in osrm-extract. [Project-OSRM#6354](Project-OSRM#6354)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@TheMarexTheMarexTheMarex approved these changes

@danpatdanpatAwaiting requested review from danpat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI build gcc-9-release-i686 is broken

2 participants

@mjjbell@TheMarex
[8]ページ先頭
©2009-2025 Movatter.jp