- Notifications
You must be signed in to change notification settings - Fork309
Update private_key.md#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Update private_key.md#81
Uh oh!
There was an error while loading.Please reload this page.
Conversation
For not making readers confused by giving them the idea that Bitcoin secret and private key are separated things.
I agree, the turn of the sentence is a bit weird though.
|
By getting Nicolas advice.
Sir, how do you think that below content will be attached in "private key" section as a Tip? |
I saw like that in BIP38 (Part 2) section.
Please anyone tells me if it's something wrong or not. |
Using Base58 does not increase security. It is just a standard to present and import public key in a human friendly way. Code should normally use
This sentence is strange. Maybe should you add some punctuation or remove "But for preventing from being confused". |
Bitcoin Address is the hash of the public key encoded in Base58. |
Thank for explanations.I personally think that in that context, "But for preventing from being confused" is better placed there for understanding. So, I put a punctuation at the end of it.
Add contents about CombineSignatures()
@bokobza I resolved this conflict the same way we resolved back then. As you can see it didn't get resolved, just like back then. Do you remember what was the GitHub bug we encountered and how we solved it? |
I was confused when I was first reading this section by Key privateKey = new Key(); // generate a random private keynew Key() can be said as a private key? I think it's more near to a kind of key object.So I edit that, if it's not appropriate, I will back to the original one.And I add some contents for giving background basics about Base64, Base58 etc.
Before sending the transaction to the network, examine the need of CombineSignatures() method. | ||
Try to compare a full detail of transaction between bobSigned and fullySigned. | ||
It will seem both are identical. | ||
For this reason, it seems like the CombineSignatures() method is needless because mulit-signing has achieved without the CombineSignatures() method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typomulit
.BuildTransaction(sign: false); | ||
Transaction aliceSigned = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
identation
.AddKeys(alice) | ||
.SignTransaction(unsignedNew); | ||
Transaction bobSigned = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
identation
bitcoin_transfer/bitcoin_address.md Outdated
The Base58Check encoding has some neat features, such as checksums to prevent typos and a lack of ambiguous characters such as '0' and 'O'. | ||
The Base58Check encoding also provides a consistent way to determine the network of a given address; preventing a wallet from sending MainNet coins to a TestNet address. | ||
## Encoindg schemes {# encoindg-schemes} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo Encoindg
Thanks, Nicolas. I edited. I wonder this. |
I also wonder this point. From above statement, can I consider the process of generating a Bitcoin address by a ScriptPubKey and network type as the same process of generating a Bitcoin address by a publicKey hash and network, except for direction(forwards for the latter, backwards for the former) and the fact that a ScriptPubKey only contains additional script commands, compared to a publicKey hash? Can a ScriptPubKey be said as an address? Or can it be said as a value? |
|
Thanks the review.
I thought this way,"Is it just a key object rather than specifying it as a private key?" or "Should it be named by keyObject rather than a privateKey?", when I was seeing this code:
Fixed this way:
I think RNGCryptoServiceProvider things would be helpful for readers to understand widely, so I want to add explanations by your suggestion like this: |
I prefer the book does not go into such details. People can easily look the source code, the only thing they need to know is that the default is using a secure RNG. |
youngminpark2559 commentedNov 21, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Okay, I agree on it and I'll keep that point in mind when I'm writing. I have some questions on the ScriptPubKey page: Does that mean some ScriptPubKey doesn't contain the hashed public key like this?: I understood like this. But this sentence: Hashed public key is the thing permitting someone to spend the coin which is the task related to proof the ownership of the coin? Under my understanding, I think hashed public key just represents the recipient like the address, not being related to some tasks of permitting coins. ScriptPubKey seems like it doesn't have the network information because hashed public key doesn't have it. |
bitcoin_transfer/blockchain.md Outdated
@@ -4,8 +4,8 @@ | |||
A Blockchain is composed of blocks. And each block shapes the chain by referencing the previous block. A block is composed of a block header and transaction(s). | |||
See the illustraion depicting a block and a blockchain, drawn by Youngmin Park, in the following link: | |||
See the illustraion depicting a block and a blockchain, drawn by Youngmin Park(Youngmtool), in the following link: |
NicolasDorierNov 27, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
*illustraion typo, and a TxIn IS an input. This is not a different thing.
@NicolasDorier Hope you review this thread from top one by one and give the opinion: And if you don't mind, I want to hear about above question of ScriptPubKey. |
For not making readers confused by giving them the idea that Bitcoin secret and private key are separated things.