Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update RegionNavigationRegistrationExtensions.cs#3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dansiegel merged 1 commit intoPrismLibrary:masterfromjpislas:patch-1
May 22, 2024

Conversation

@jpislas
Copy link
Contributor

@jpislasjpislas commentedMay 20, 2024•
edited
Loading

Allow for registering a view for navigation using type. This method already exists but is currently private. This is existing function so no tests created.

## Description of Change

Make existing function public.

Changed:

  • private static IContainerRegistry RegisterForRegionNavigation => public static IContainerRegistry RegisterForRegionNavigation

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

Allow for registering a view for navigation using type. This method already exists but is currently private.
@dansiegel
Copy link
Member

@jpislas can you please give us some context on why you feel this is needed as part of the public API?

@jpislas
Copy link
ContributorAuthor

@jpislas can you please give us some context on why you feel this is needed as part of the public API?

@dansiegel I register my views using attributes/reflection and don't have access to strongly type them so I end up having to work around it. Its also the way it is set up for standard non region based navigation registration, so it would be consistent with existing functionality. For example:

            if (attribute != null)            {                if (attribute.UseRegionNavigation)                    containerRegistry.RegisterForRegionNavigation(t, attribute.ViewModelType, t.Name);                else                    containerRegistry.RegisterForNavigation(t, attribute.ViewModelType, t.Name);            }

@dansiegeldansiegel merged commit17c6d31 intoPrismLibrary:masterMay 22, 2024
@jpislasjpislas deleted the patch-1 branchMay 22, 2024 13:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dansiegeldansiegeldansiegel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpislas@dansiegel
[8]ページ先頭
©2009-2025 Movatter.jp